[decomp] make use of the generated load boundary data

[ManDude]

No description provided.

[coveralls]

Pull Request Test Coverage Report for Build 1500849870

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 55.644%

---

Totals
Change from base Build 1498012185:	0.0%
Covered Lines:	40425
Relevant Lines:	72649

---

💛 - Coveralls

[water111]

looks good - just one comment on the doarray macro

[water111]

I think this will read past the end of the array on the last iteration through. I think you'll need to put a (let ((,val (-> ,arr ,i))) inside of the while to get val with the right type, and not read past the end.

[ManDude]

This is the original code:

(let* ((gp-0 (-> *static-load-boundary-list* length))
      (s5-0 0)
      (a0-1 (-> *static-load-boundary-list* s5-0))
      )
  (while (< s5-0 gp-0)
   (load-boundary-from-template (the-as (array object) a0-1))
   (+! s5-0 1)
   (set! a0-1 (-> *static-load-boundary-list* s5-0))
   )
  )

val will be out of bounds after the last iteration, but that value won't ever be used because the while condition will fail anyway.

[water111]

ah ok, in that case let's do the same thing they did. Agreed that it won't cause problems. Unless you have an array that ends at the end of memory, but they never do this.