Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[decomp] cleanup default-menu, fix dangerous IOP bug, autoconvert ints in pairs to/from bintegers #997

Merged
merged 15 commits into from
Dec 9, 2021
Merged

[decomp] cleanup default-menu, fix dangerous IOP bug, autoconvert ints in pairs to/from bintegers #997

merged 15 commits into from
Dec 9, 2021

Conversation

ManDude
Copy link
Member

@ManDude ManDude commented Dec 5, 2021

No description provided.

@coveralls
Copy link

coveralls commented Dec 5, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1543126578

  • 30 of 40 (75.0%) changed or added relevant lines in 6 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.009%) to 54.786%
Changes Missing Coverage Covered Lines Changed/Added Lines %
decompiler/util/data_decompile.cpp 0 1 0.0%
goalc/debugger/Debugger.cpp 20 29 68.97%
Files with Coverage Reduction New Missed Lines %
goalc/compiler/compilation/Static.cpp 1 82.98%
goalc/debugger/Debugger.cpp 1 72.58%
game/kernel/kscheme.cpp 2 69.21%
Totals Coverage Status
Change from base Build 1539729576: 0.009%
Covered Lines: 40777
Relevant Lines: 74429
💛 - Coveralls

@ManDude
Copy link
Member Author

ManDude commented Dec 5, 2021

fixes #995 and #996

@ManDude ManDude marked this pull request as draft December 5, 2021 17:38
@ManDude ManDude marked this pull request as ready for review December 6, 2021 04:43
@water111 water111 merged commit 59a1202 into open-goal:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ManDude @coveralls @water111