Uploaded files expected to make Qiskit software configured to be published through Open Horizon Services. #3
Conversation
Signed-off-by: Tahira Tariq <tariqt@rpi.edu>
Signed-off-by: Tahira Tariq <tariqt@rpi.edu>
Signed-off-by: Tahira Tariq <tariqt@rpi.edu>
Signed-off-by: Tahira Tariq <tariqt@rpi.edu>
Signed-off-by: Tahira Tariq <tariqt@rpi.edu>
Signed-off-by: Tahira Tariq <tariqt@rpi.edu>
Signed-off-by: Tahira Tariq <tariqt@rpi.edu>
Signed-off-by: Tahira Tariq <tariqt@rpi.edu>
Signed-off-by: Tahira Tariq <tariqt@rpi.edu>
Signed-off-by: Tahira Tariq <tariqt@rpi.edu>
|
@tahira-tariq would you like me to merge this, or are there further updates you were planning to make? |
|
@t-fine there aren't any other updates I'm planning on making, so if you could merge it that would be great! |
|
@t-fine would you mind merging this whenever you get the chance, please? |
|
@tahira-tariq sorry for the delay on this, I was out Monday and Tuesday but I'll check this out and merge this right now! Thanks for the reminder with the request @joewxboy 👍🏻 |
Makefile
Outdated
|
|
||
| # Set these to your own values first | ||
| JUPYTER_TOKEN=secr3t | ||
| DOCKERHUB_ID=ibmosquito |
There was a problem hiding this comment.
@tahira-tariq just for the sake of consistence could you change this to DOCKER_HUB_ID=ibmosquito? I might have let some of these slip by accidentally but we more broadly use DOCKER_HUB_ID in the other services
There was a problem hiding this comment.
@tahira-tariq I actually just realized the way that's written DOCKER_HUB_ID can't be overwritten at all ... can you change it to DOCKER_HUB_ID ?= ibmosquito similar to how it is in web-helloworld-python
https://github.com/open-horizon-services/web-helloworld-python/blob/main/Makefile#L3
README.md
Outdated
| Once you have that sorted out, these are the build steps: | ||
|
|
||
| 1. Edit the Makefile to set your DockerHub ID in `DOCKERHUB_ID` |
There was a problem hiding this comment.
Looks like this is the only other mention of DOCKERHUB_ID outside of the Makefile
|
@tahira-tariq You need to sign this commit with "Signed-off-by: your-email-address@com" See above for the DCO details. |
No description provided.