[ Informal Audit ] validate 0 length version in dispatcher channelope…

…ninit
open-ibc · Sep 9, 2024 · f1ade7e · f1ade7e
1 parent 7de25a5
commit f1ade7e
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/contracts/core/Dispatcher.sol b/contracts/core/Dispatcher.sol
@@ -178,6 +178,9 @@ contract Dispatcher is Ownable2StepUpgradeable, UUPSUpgradeable, ReentrancyGuard
         if (connectionHops.length < 2 || bytes(counterpartyPortId).length == 0) {
             revert IBCErrors.invalidCounterParty();
         }
+        if(bytes(version).length == 0) {
+            revert IBCErrors.invalidVersion();
+        }
 
         emit ChannelOpenInit(msg.sender, version, ordering, feeEnabled, connectionHops, counterpartyPortId);
     }

diff --git a/contracts/libs/IbcErrors.sol b/contracts/libs/IbcErrors.sol
@@ -30,6 +30,7 @@ library IBCErrors {
     error notEnoughGas();
     error invalidCharacter();
     error invalidPacket();
+    error invalidVersion();
 
     // packet sequence related errors.
     error invalidPacketSequence();

diff --git a/test/Dispatcher/Dispatcher.t.sol b/test/Dispatcher/Dispatcher.t.sol
@@ -176,6 +176,19 @@ abstract contract ChannelHandshakeTestSuite is ChannelHandshakeUtils {
             }
         }
     }
+
+    function test_chanOpenInit_fail_invalidVersion() public {
+        // When localEnd initiates, counterparty version is only available in channelOpenAck
+        ChannelHandshakeSetting[8] memory settings = createSettings2(true);
+        for (uint256 i = 0; i < settings.length; i++) {
+            LocalEnd memory le = _local;
+            ChannelEnd memory re = _remote;
+            // no remote version applied in openChannel
+            le.versionCall = "";
+            vm.expectRevert(abi.encodeWithSelector(IBCErrors.invalidVersion.selector));
+            channelOpenInit(le, re, settings[i], false);
+        }
+    }
 }
 
 contract ChannelHandshakeTest is ChannelHandshakeTestSuite {