raunak/addNpmTesting #150
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,17 +20,17 @@ | |
| - name: LightClient | ||
| description: 'DummyLightClient' | ||
| factoryName: 'DummyLightClient' | ||
| deployer: 'KEY_DEPLOYER' | ||
|
|
||
| - name: Ibc | ||
| description: 'IBC library' | ||
| factoryName: 'Ibc' | ||
| deployer: 'KEY_DEPLOYER' | ||
|
|
||
| - name: IbcUtils | ||
| description: 'IBC utils library' | ||
| factoryName: 'IbcUtils' | ||
| deployer: 'KEY_DEPLOYER' | ||
|
|
||
| - name: Dispatcher | ||
| description: 'IBC Core contract' | ||
|
|
@@ -40,12 +40,12 @@ | |
| address: '{{Ibc}}' | ||
| - name: 'contracts/libs/IbcUtils.sol:IbcUtils' | ||
| address: '{{IbcUtils}}' | ||
| deployer: 'KEY_DEPLOYER' | ||
|
|
||
| - name: FeeVault | ||
| description: 'FeeVault' | ||
| factoryName: 'FeeVault' | ||
| deployer: 'KEY_DEPLOYER' | ||
|
|
||
| - name: DispatcherProxy | ||
| description: 'Dispatcher proxy contract' | ||
|
|
@@ -58,20 +58,20 @@ | |
| args: | ||
| - 'polyibc.{{chain.chainName}}.' | ||
| - '{{FeeVault}}' | ||
| deployer: 'KEY_DEPLOYER' | ||
|
|
||
| - name: UC | ||
| description: 'Universal Chanel IBC-middleware contract' | ||
| factoryName: 'UniversalChannelHandler' | ||
| deployer: 'KEY_DEPLOYER' | ||
| libraries: | ||
| - name: 'contracts/libs/IbcUtils.sol:IbcUtils' | ||
| address: '{{IbcUtils}}' | ||
|
|
||
| - name: UCProxy | ||
| description: 'Universal Chanel IBC-middleware proxy' | ||
| factoryName: 'ERC1967Proxy' | ||
| deployer: 'KEY_DEPLOYER' | ||
| deployArgs: | ||
| - '{{UC}}' | ||
| - '$INITARGS' | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,12 +1,11 @@ | ||||||
| # These accounts are derived from a test mnemonic by Anvil/Hardhat and used for testing purposes only. | ||||||
| - name: 'KEY_DEPLOYER' | ||||||
| privateKey: '{{ DUMMY_DEPLOYER_PRIVATE_KEY }}' | ||||||
|
There was a problem hiding this comment. Remove trailing spaces. Trailing spaces detected on line 3. - privateKey: '{{ DUMMY_DEPLOYER_PRIVATE_KEY }}'
+ privateKey: '{{ DUMMY_DEPLOYER_PRIVATE_KEY }}'Committable suggestion
Suggested change
|
||||||
|
|
||||||
| # Dapp accounts | ||||||
| - name: 'KEY_DAPP1' | ||||||
| privateKey: '{{ DAPP_PRIVATE_KEY_1 }}' | ||||||
| - name: 'KEY_DAPP2' | ||||||
| privateKey: '{{ DAPP_PRIVATE_KEY_2 }}' | ||||||
| - name: 'KEY_DAPP3' | ||||||
| privateKey: '{{ DAPP_PRIVATE_KEY_3 }}' | ||||||
|
There was a problem hiding this comment. Remove trailing spaces. Trailing spaces detected on line 11. - privateKey: '{{ DAPP_PRIVATE_KEY_3 }}'
+ privateKey: '{{ DAPP_PRIVATE_KEY_3 }}'Committable suggestion
Suggested change
Toolsyamllint
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,20 +35,36 @@ | |
| # signature: signature of method to call for this tx | ||
| # args: args to make the function call with, need to be compatible with the signature | ||
|
|
||
| - name: OptimisticProofVerifier | ||
| description: 'OptimisticProofVerifier' | ||
| factoryName: 'OptimisticProofVerifier' | ||
| deployer: 'KEY_DEPLOYER' | ||
| deployArgs: | ||
| - '{{PolymerL2OutputOracleProxyAddress}}' | ||
|
|
||
| - name: OptimisticLightClient | ||
| description: 'OptimisticLightClient' | ||
| factoryName: 'OptimisticLightClient' | ||
| deployer: 'KEY_DEPLOYER' | ||
| deployArgs: | ||
| - 0 | ||
| - '{{OptimisticProofVerifier}}' | ||
| - '{{L1BlockAddress}}' | ||
|
|
||
| - name: DummyLightClient | ||
| description: 'DummyLightClient' | ||
| factoryName: 'DummyLightClient' | ||
| deployer: 'KEY_DEPLOYER' | ||
|
|
||
| - name: Ibc | ||
| description: 'IBC library' | ||
| factoryName: 'Ibc' | ||
| deployer: 'KEY_DEPLOYER' | ||
|
|
||
| - name: IbcUtils | ||
| description: 'IBC utils library' | ||
| factoryName: 'IbcUtils' | ||
| deployer: 'KEY_DEPLOYER' | ||
|
|
||
| - name: Dispatcher | ||
| description: 'IBC Core contract' | ||
|
|
@@ -58,12 +74,12 @@ | |
| address: '{{Ibc}}' | ||
| - name: 'contracts/libs/IbcUtils.sol:IbcUtils' | ||
| address: '{{IbcUtils}}' | ||
| deployer: 'KEY_DEPLOYER' | ||
|
|
||
| - name: FeeVault | ||
| description: 'FeeVault' | ||
| factoryName: 'FeeVault' | ||
| deployer: 'KEY_DEPLOYER' | ||
|
|
||
| - name: DispatcherProxy | ||
| description: 'Dispatcher proxy contract' | ||
|
|
@@ -76,20 +92,20 @@ | |
| args: | ||
| - 'polyibc.{{chain.chainName}}.' | ||
| - '{{FeeVault}}' | ||
| deployer: 'KEY_DEPLOYER' | ||
|
|
||
| - name: UC | ||
| description: 'Universal Chanel IBC-middleware contract' | ||
| factoryName: 'UniversalChannelHandler' | ||
| deployer: 'KEY_DEPLOYER' | ||
| libraries: | ||
| - name: 'contracts/libs/IbcUtils.sol:IbcUtils' | ||
| address: '{{IbcUtils}}' | ||
|
|
||
| - name: UCProxy | ||
| description: 'Universal Chanel IBC-middleware proxy' | ||
| factoryName: 'ERC1967Proxy' | ||
| deployer: 'KEY_DEPLOYER' | ||
| deployArgs: | ||
| - '{{UC}}' | ||
| - '$INITARGS' | ||
|
|
@@ -115,7 +131,7 @@ | |
| # Contract Setup below | ||
| - name: DispatcherUpgrade | ||
| description: 'UUPS Upgrade for dispatcher contract implementation' | ||
| deployer: 'KEY_DEPLOYER' | ||
RnkSngh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| signature: "upgradeTo(address)" | ||
| address: '{{DispatcherProxy}}' | ||
| factoryName: "Dispatcher" | ||
|
|
@@ -124,7 +140,7 @@ | |
|
|
||
| - name: DispatcherUpgrade | ||
| description: 'UUPS Upgrade for dispatcher contract implementation' | ||
| deployer: 'KEY_DEPLOYER' | ||
RnkSngh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| signature: "upgradeTo(address)" | ||
| address: '{{DispatcherProxy}}' | ||
| factoryName: "Dispatcher" | ||
|
|
@@ -133,29 +149,29 @@ | |
|
|
||
| - name: UCH Upgrade | ||
| description: 'Upgrade for uch contract' | ||
| deployer: 'KEY_DEPLOYER' | ||
| signature: "upgradeTo(address)" | ||
| address: '{{ UCProxy }}' | ||
RnkSngh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| factoryName: "UC" | ||
| args: | ||
| - '{{UC}}' | ||
|
|
||
| - name: DispatcherClientSetup-Connection-0 | ||
| description: 'Setup client for dispatcher contracts' | ||
| deployer: 'KEY_DEPLOYER' | ||
RnkSngh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| signature: "setClientForConnection(string,address)" | ||
| address: '{{DispatcherProxy}}' | ||
| factoryName: "Dispatcher" | ||
| args: | ||
| - 'connection-1' | ||
| - '{{DummyLightClient}}' | ||
|
|
||
| - name: DispatcherClientSetup-Connection-1 | ||
| description: 'Setup client for dispatcher contracts' | ||
| deployer: 'KEY_DEPLOYER' | ||
| signature: "setClientForConnection(string,address)" | ||
| address: '{{DispatcherProxy}}' | ||
| factoryName: "Dispatcher" | ||
| args: | ||
| - 'connection-3' | ||
| - '{{DummyLightClient}}' | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -18,7 +18,7 @@ | |||||
|
|
||||||
| - name: DispatcherUpgrade | ||||||
| description: 'UUPS Upgrade for dispatcher contract implementation' | ||||||
| deployer: 'KEY_DEPLOYER' | ||||||
|
There was a problem hiding this comment. Remove trailing spaces. Trailing spaces detected on line 21. - deployer: 'KEY_DEPLOYER'
+ deployer: 'KEY_DEPLOYER'Committable suggestion
Suggested change
Toolsyamllint
|
||||||
| signature: "upgradeTo(address)" | ||||||
| address: '{{DispatcherProxy}}' | ||||||
| factoryName: "Dispatcher" | ||||||
|
|
@@ -27,9 +27,9 @@ | |||||
|
|
||||||
| - name: UCH Upgrade | ||||||
| description: 'Upgrade for uch contract' | ||||||
| deployer: 'KEY_DEPLOYER' | ||||||
|
There was a problem hiding this comment. Remove trailing spaces. Trailing spaces detected on line 30. - deployer: 'KEY_DEPLOYER'
+ deployer: 'KEY_DEPLOYER'Committable suggestion
Suggested change
Toolsyamllint
|
||||||
| signature: "upgradeTo(address)" | ||||||
| address: '{{ UCProxy }}' | ||||||
|
There was a problem hiding this comment. Remove trailing spaces. Trailing spaces detected on line 32. - address: '{{ UCProxy }}'
+ address: '{{ UCProxy }}'Committable suggestion
Suggested change
Toolsyamllint
|
||||||
| factoryName: "UC" | ||||||
| args: | ||||||
| - '{{UC}}' | ||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -187,7 +187,7 @@ export async function deployToChain( | |
| } | ||
|
|
||
| // @ts-ignore | ||
| const env: StringToStringMap = {...process.env , chain , }; | ||
| if (!forceDeployNewContracts) { | ||
| // Only read from existing contract files if we want to deploy new ones | ||
| await readDeploymentFilesIntoEnv(env, chain); | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing spaces.
Trailing spaces detected on line 13.
Committable suggestion
Tools
yamllint