XCOPY follow up fixes #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcmu-runner can't determine whether the device(s) referred to in XCOPY Copy Source/Copy Destination (CSCD) descriptors should be accessible to the initiator via transport settings, ACLs, etc. Consequently, fail XCOPY requests with CSCD descriptors which refer to any device other than where the XCOPY request is processed. References: CVE-2020-28374 Fixes: 9c86bd0 ("tcmur: Add emulate XCOPY command support") Signed-off-by: David Disseldorp <ddiss@suse.de> Reviewed-by: Lee Duncan <lduncan@suse.com>
EXTENDED COPY inline data is currently unprocessed, so fail requests if the INLINE DATA LENGTH field indicates presence of any. Fixes: 9c86bd0 ("tcmur: Add emulate XCOPY command support") Signed-off-by: David Disseldorp <ddiss@suse.de>
The XCOPY Copy Source / Copy Destination (CSCD) parse loop currently assumes that two descriptors are present. Remove this assumption and instead use the CSCD DESCRIPTOR LIST LENGTH in case only a single CSCD descriptor is carried, referred to by both segment descriptor CSCD descriptor IDs. Fixes: 9c86bd0 ("tcmur: Add emulate XCOPY command support") Signed-off-by: David Disseldorp <ddiss@suse.de>
A null src_dev and dst_dev pointer appears to be quite possible after CSCD list parsing, so this error condition should be handled. Fixes: 9c86bd0 ("tcmur: Add emulate XCOPY command support") Signed-off-by: David Disseldorp <ddiss@suse.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch-set sits atop the cross-device XCOPY CVE fix submitted via #644 .