tcmu_read_config(): check read() return value. #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcmu-runner doesn't work correctly on Fedora 34 because it enters an infinite loop while reading the /etc/tcmu/tcmu.conf config file. The reason is that tcmu_read_config() doesn't check the read() return value, relying only on errno's value, but the latter should only be checked when read() returns -1. Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tcmu-runner doesn't work correctly on Fedora 34 because it
enters an infinite loop while reading the /etc/tcmu/tcmu.conf config
file. The reason is that tcmu_read_config() doesn't check the read()
return value, relying only on errno's value, but the latter should
only be checked when read() returns -1.
Signed-off-by: Maurizio Lombardi mlombard@redhat.com