Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEN-1192 - Move Test Case to its Own Resource #17862

Merged
merged 39 commits into from
Sep 18, 2024
Merged

GEN-1192 - Move Test Case to its Own Resource #17862

merged 39 commits into from
Sep 18, 2024

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Sep 16, 2024

Describe your changes:

  • Move test case results to its own API resource
  • Added list test case results from search endpoint
  • Remove test case result state from testSuite and testCase
    • Will be fetched from search index

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Improvement

  • I have added tests around the new logic.
  • For connector/ingestion changes: I updated the documentation.

@TeddyCr
feat: indexed test case results
182c23b
@TeddyCr
feat: added indexation logic for test case results
2cac2af
@TeddyCr
style: ran java linting
bba9863
@TeddyCr
Merge remote-tracking branch 'upstream/main' into GEN-1213
2867b9a
@TeddyCr
fix: IDE warnigns
6d4f11c
@TeddyCr
chore: added test case results migration
396b37f
@TeddyCr
Merge remote-tracking branch 'upstream/main' into GEN-1213
121d91e
@TeddyCr
style: ran java linting
1fd5bc9
@TeddyCr
fix: postgres migration column json ref
fb0f43d
@TeddyCr
Merge branch 'main' into GEN-1213
7086ea0
@TeddyCr
empty commit to trigger queued
c728578
@TeddyCr
Merge remote-tracking branch 'upstream/main' into GEN-1213
3b1cc4c
@TeddyCr
Merge remote-tracking branch 'upstream/main' into GEN-1213
87c366d
@TeddyCr
Merge remote-tracking branch 'upstream/main' into GEN-1213
930d039
@TeddyCr
Merge remote-tracking branch 'upstream/main' into GEN-1213
4381155
@TeddyCr
Merge remote-tracking branch 'upstream/main' into GEN-1192
72f4a2c
@TeddyCr
Merge remote-tracking branch 'upstream/main' into GEN-1192
ae8fe82
@TeddyCr
Merge remote-tracking branch 'upstream/main' into GEN-1192
acbfb63
@TeddyCr
Merge remote-tracking branch 'upstream/main' into GEN-1192
b111f4e
@TeddyCr
Merge remote-tracking branch 'upstream/main' into GEN-1192
527e059
@TeddyCr
Merge remote-tracking branch 'upstream/main' into GEN-1192
08ec447
@TeddyCr
chore: extracted test case results to its own resource
75ea6ae
@TeddyCr
Merge remote-tracking branch 'upstream/main' into GEN-1192
695953d
@TeddyCr
Merge remote-tracking branch 'upstream/main' into GEN-1192
24b9b60
@TeddyCr
chore: fix failing tests
52e8169
@TeddyCr
Merge remote-tracking branch 'upstream/main' into GEN-1192
ee462b9
@TeddyCr
chore: move testCaseResult state from testSuite and testCase to dynam…
6cecfe1 
…ic field fetched from test case results search index
@TeddyCr
Merge remote-tracking branch 'upstream/main' into GEN-1192
cb63b65
@TeddyCr
chore: clean up test case repository
27417e1
@TeddyCr
style: ran java linting
c7136e6
@TeddyCr TeddyCr marked this pull request as ready for review September 17, 2024 08:51
@TeddyCr TeddyCr requested a review from a team as a code owner September 17, 2024 08:51
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 17, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@TeddyCr TeddyCr enabled auto-merge (squash) September 18, 2024 06:00
mohityadav766
mohityadav766 reviewed Sep 18, 2024
View reviewed changes
...a-service/src/test/java/org/openmetadata/service/resources/dqtests/TestCaseResourceTest.java
return TestUtils.get(target, TestCaseResultResource.TestCaseResultList.class, authHeader);
}

protected void validateListTestCaseResultsFromSearchWithPagination(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

mohityadav766
mohityadav766 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@mohityadav766 mohityadav766 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TeddyCr TeddyCr enabled auto-merge (squash) September 18, 2024 09:58
@TeddyCr TeddyCr merged commit 33c50ef into open-metadata:main Sep 18, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushi30 sushi30 sushi30 left review comments

@mohityadav766 mohityadav766 mohityadav766 approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TeddyCr @sushi30 @mohityadav766