Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: added seconds to human-readable format scale for test case graph #17926

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Minor: added seconds to human-readable format scale for test case graph #17926

merged 6 commits into from
Sep 20, 2024
+98 −4

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Sep 19, 2024 •
edited
Loading

Describe your changes:

Minor: added seconds to human-readable format scale for test case graph

image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Sep 19, 2024
@TeddyCr
Copy link
Contributor

TeddyCr commented Sep 19, 2024

@ShaileshParmar11 you need to treat it as second. The millisecond value is a bug that will be fixed (we have an open PR)

@ShaileshParmar11
Copy link
Contributor Author

@ShaileshParmar11 you need to treat it as second. The millisecond value is a bug that will be fixed (we have an open PR)

Thanks for the update, Ill make necessary changes

@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.33% (37382/58110) 40.97% (14798/36116) 43.08% (4509/10467)

@ShaileshParmar11 ShaileshParmar11 changed the title Minor: added milliseconds to human-readable format scale for test case graph Minor: added seconds to human-readable format scale for test case graph Sep 20, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ShaileshParmar11 ShaileshParmar11 merged commit 13552a6 into main Sep 20, 2024
16 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the yAxis-scale-for-graph branch September 20, 2024 13:17
ShaileshParmar11 added a commit that referenced this pull request Sep 20, 2024
@ShaileshParmar11
Minor: added seconds to human-readable format scale for test case gra…
3ba2fd8 
…ph (#17926)

* Minor: added milliseconds to human-readable format scale for test case graph

* addressing comment

* fixed unit test

* addressing comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani chirag-madlani is a code owner

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShaileshParmar11 @TeddyCr @Sachin-chaurasiya