Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Fix initialization bug of override cfg #918

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

ZwwWayne
Copy link
Collaborator

This PR fixes the bug in the initialize function, which will change the original init_cfg after override some keys.
This behavior will cause an error when one config is used in many other modules as the config will be changed after it has been used once.
One test case that will cause the failure is here.

Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for fixing this bug.

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #918 (9488839) into master (9d80f56) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9488839 differs from pull request most recent head 024d5f4. Consider uploading reports for the commit 024d5f4 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #918   +/-   ##
=======================================
  Coverage   64.86%   64.87%           
=======================================
  Files         148      148           
  Lines        9193     9195    +2     
  Branches     1647     1647           
=======================================
+ Hits         5963     5965    +2     
  Misses       2903     2903           
  Partials      327      327           
Flag Coverage Δ
unittests 64.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/cnn/utils/weight_init.py 91.66% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d80f56...024d5f4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants