Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formatting.py #10743

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Update formatting.py #10743

merged 3 commits into from
Aug 8, 2023

Conversation

captainIT
Copy link
Contributor

Motivation

PackDetInputs 使用默认构造函数的meta_keys,但数据增强,没用flip的时候会报错

Modification

这是mmsegmentation的处理方式

https://github.com/open-mmlab/mmsegmentation/blob/30a3f94f3e2916e27fa38c67cc3b8c69c1893fe8/mmseg/datasets/transforms/formatting.py#L97C22-L97C22

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2023

CLA assistant check
All committers have signed the CLA.

@noreenanwar
Copy link

Motivation

PackDetInputs 使用默认构造函数的meta_keys,但数据增强,没用flip的时候会报错

Modification

这是mmsegmentation的处理方式

https://github.com/open-mmlab/mmsegmentation/blob/30a3f94f3e2916e27fa38c67cc3b8c69c1893fe8/mmseg/datasets/transforms/formatting.py#L97C22-L97C22

I got the issue for 'border' like AssertionError: border is not found in results, the valid keys are ['img_path', 'img_id', 'seg_map_path', 'height', 'width', 'instances', 'sample_idx', 'img', 'img_shape', 'ori_shape', 'scale', 'scale_factor', 'keep_ratio', 'homography_matrix', 'gt_bboxes', 'gt_ignore_flags', 'gt_bboxes_labels'].

@hhaAndroid
Copy link
Collaborator

May I know which configuration?

@noreenanwar
Copy link

May I know which configuration?

For me it's centernet_r18-dcnv2_8xb16-crop512-140e_coco.py.

hhaAndroid
hhaAndroid previously approved these changes Aug 8, 2023
@hhaAndroid
Copy link
Collaborator

May I know which configuration?

For me it's centernet_r18-dcnv2_8xb16-crop512-140e_coco.py.

You need include 'border' in PackDetInputs

    dict(
        type='PackDetInputs',
        meta_keys=('img_id', 'img_path', 'ori_shape', 'img_shape', 'border'))

@hhaAndroid hhaAndroid changed the base branch from main to dev-3.x August 8, 2023 01:47
@hhaAndroid hhaAndroid dismissed their stale review August 8, 2023 01:47

The base branch was changed.

@hhaAndroid hhaAndroid merged commit 4d2fbb0 into open-mmlab:dev-3.x Aug 8, 2023
1 of 2 checks passed
@OpenMMLab-Assistant-004

Hi @captainIT,

We'd like to express our appreciation for your valuable contributions to the mmdetection. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants