Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add optional score threshold option to coco_error_analysis.py #11117

Merged
merged 3 commits into from
Nov 7, 2023
Merged

[Feature] Add optional score threshold option to coco_error_analysis.py #11117

merged 3 commits into from
Nov 7, 2023

Conversation

guyleaf
Copy link
Contributor

@guyleaf guyleaf commented Nov 1, 2023 •
edited
Loading

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

In some models, e.g., DETR, it does not support filtering score after prediction.
By adding score threshold option, we could filter the detection bboxes in flexible way.

It is also a common case to visualize the actual performance in dataset.
For example, positive bbox with low confident score will affect the AP and AR going higher.

Modification

  • Add optional score threshold to coco_error_analysis.py
  • Filter the detection bboxes with the score threshold when user set it.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMPreTrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@hhaAndroid
Copy link
Collaborator

@guyleaf Please fix the lint

@guyleaf guyleaf force-pushed the guyleaf/enchance-coco-error-analysis branch from 2302345 to 8f354f9 Compare November 6, 2023 12:10
@guyleaf
Copy link
Contributor Author

guyleaf commented Nov 6, 2023

@guyleaf Please fix the lint

Done.

@hhaAndroid hhaAndroid merged commit 4a516c3 into open-mmlab:dev-3.x Nov 7, 2023
8 of 10 checks passed
yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
@guyleaf @yumion
[Feature] Add optional score threshold option to coco_error_analysis.…
5e3a902 
…py (open-mmlab#11117)
yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
@guyleaf @yumion
[Feature] Add optional score threshold option to coco_error_analysis.…
8337cfb 
…py (open-mmlab#11117)
ChuaHanChong added a commit to Porolis-Technologies/AI_mmdetection that referenced this pull request Nov 15, 2024
@ChuaHanChong @AwePhD
@Divadi @aaronzs @LRJKD @hhaAndroid @Crescent-Saturn @guyleaf @keyhsw @Cycyes @xushilin1 @okotaku @ImJaewooChoi @returnL @ilcopione @adnan-mujagic @R-Fehler @Jun0922 @RangiLyu @Baboom-l
Update to latest commit (#2)
7dae0d9 
* Fix  docstring for dimension of targets argument (open-mmlab#11058)

* Fix Grounding DINO nan when class tokens exceeds 256 (open-mmlab#11066)

* Fix broken links in README.md (open-mmlab#11060)

* Fixed the issue where the directory level of the youtubevis2coco… (open-mmlab#11086)

* Fixed the issue where type and by_epoch in loop_cfg exist simult… (open-mmlab#11085)

* Support ODinW and evaluate (open-mmlab#11105)

* [MMSIG#357] Add new configs for panoptic_fpn (open-mmlab#11109)

* [Feature] Add optional score threshold option to coco_error_analysis.py (open-mmlab#11117)

* Support LVIS chunked evaluation and image chunked inference of GLIP (open-mmlab#11136)

* Replace partially weighted download links with OpenXLab for the Faster-RCNN (open-mmlab#11173)

* add odinw configs and evaluation results of GLIP(open-mmlab#11175)

* Add GroundingDINO on ODinW results, and support caption prompt of GroundingDINO (open-mmlab#11187)

* MMGroundingDINO-A replicable and more comprehensive GroundingDINO (open-mmlab#11295)

Co-authored-by: Cycyes <92714336+Cycyes@users.noreply.github.com>

* finetune MM-GDINO on ov_coco and ov_lvis (open-mmlab#11304)

* [Feature] Add RTMDet Swin / ConvNeXt (open-mmlab#11259)

* Fix bug in `convert_coco_format` (open-mmlab#11251)

* Fix CO-DETR load_from url in config (open-mmlab#11220)

* Update README and refine of MM-GDINO (open-mmlab#11298)

* Fixed mask shape after Albu postprocess (open-mmlab#11280)

* update English version of md (open-mmlab#11336)

* Fix one of the CO-DETR config files (open-mmlab#11325)

* replace '.jpg' instead of 'jpg' to guarantee replacing file ending (open-mmlab#11340)

* Bump version to 3.3.0 (open-mmlab#11338)

* [Bug Fix] video_demo bug fixed for issue#11353 (open-mmlab#11451)

* use `lerp` in ema (open-mmlab#11442)

* fix:grounding_pretrain_text_trans_negative_label (open-mmlab#11404)

* Release MM-GroundingDINO SwinB and SwinL Weights (open-mmlab#11458)

---------

Co-authored-by: Mathias Réus <93187038+AwePhD@users.noreply.github.com>
Co-authored-by: Jinhyung Park <jinhyun1@andrew.cmu.edu>
Co-authored-by: Aaron Sun <aaronzs@users.noreply.github.com>
Co-authored-by: LRJKD <101466907+LRJKD@users.noreply.github.com>
Co-authored-by: Haian Huang(深度眸) <1286304229@qq.com>
Co-authored-by: Lei Lei <18294546+Crescent-Saturn@users.noreply.github.com>
Co-authored-by: Leaf Ying <43506966+guyleaf@users.noreply.github.com>
Co-authored-by: key <30455795+keyhsw@users.noreply.github.com>
Co-authored-by: Cycyes <92714336+Cycyes@users.noreply.github.com>
Co-authored-by: Shilin Xu <xsl.cmd@gmail.com>
Co-authored-by: takuoko <to78314910@gmail.com>
Co-authored-by: Jaewoo Choi <130287161+honeybadger78@users.noreply.github.com>
Co-authored-by: Lintch <44701395+returnL@users.noreply.github.com>
Co-authored-by: ilcopione <109541948+ilcopione@users.noreply.github.com>
Co-authored-by: Adnan Mujagic <adnanmujagic@outlook.com>
Co-authored-by: R-Fehler <36566250+R-Fehler@users.noreply.github.com>
Co-authored-by: Jun0922 <89365607+Jun0922@users.noreply.github.com>
Co-authored-by: RangiLyu <lyuchqi@gmail.com>
Co-authored-by: Chen Qibo <69334887+Baboom-l@users.noreply.github.com>
ChuaHanChong added a commit to Porolis-Technologies/AI_mmdetection that referenced this pull request Nov 15, 2024
@ChuaHanChong @AwePhD
@Divadi @aaronzs @LRJKD @hhaAndroid @Crescent-Saturn @guyleaf @keyhsw @Cycyes @xushilin1 @okotaku @ImJaewooChoi @returnL @ilcopione @adnan-mujagic @R-Fehler @Jun0922 @RangiLyu @Baboom-l
Update to latest commit (#3)
4c5af74 
* Fix  docstring for dimension of targets argument (open-mmlab#11058)

* Fix Grounding DINO nan when class tokens exceeds 256 (open-mmlab#11066)

* Fix broken links in README.md (open-mmlab#11060)

* Fixed the issue where the directory level of the youtubevis2coco… (open-mmlab#11086)

* Fixed the issue where type and by_epoch in loop_cfg exist simult… (open-mmlab#11085)

* Support ODinW and evaluate (open-mmlab#11105)

* [MMSIG#357] Add new configs for panoptic_fpn (open-mmlab#11109)

* [Feature] Add optional score threshold option to coco_error_analysis.py (open-mmlab#11117)

* Support LVIS chunked evaluation and image chunked inference of GLIP (open-mmlab#11136)

* Replace partially weighted download links with OpenXLab for the Faster-RCNN (open-mmlab#11173)

* add odinw configs and evaluation results of GLIP(open-mmlab#11175)

* Add GroundingDINO on ODinW results, and support caption prompt of GroundingDINO (open-mmlab#11187)

* MMGroundingDINO-A replicable and more comprehensive GroundingDINO (open-mmlab#11295)

Co-authored-by: Cycyes <92714336+Cycyes@users.noreply.github.com>

* finetune MM-GDINO on ov_coco and ov_lvis (open-mmlab#11304)

* [Feature] Add RTMDet Swin / ConvNeXt (open-mmlab#11259)

* Fix bug in `convert_coco_format` (open-mmlab#11251)

* Fix CO-DETR load_from url in config (open-mmlab#11220)

* Update README and refine of MM-GDINO (open-mmlab#11298)

* Fixed mask shape after Albu postprocess (open-mmlab#11280)

* update English version of md (open-mmlab#11336)

* Fix one of the CO-DETR config files (open-mmlab#11325)

* replace '.jpg' instead of 'jpg' to guarantee replacing file ending (open-mmlab#11340)

* Bump version to 3.3.0 (open-mmlab#11338)

* [Bug Fix] video_demo bug fixed for issue#11353 (open-mmlab#11451)

* use `lerp` in ema (open-mmlab#11442)

* fix:grounding_pretrain_text_trans_negative_label (open-mmlab#11404)

* Release MM-GroundingDINO SwinB and SwinL Weights (open-mmlab#11458)

---------

Co-authored-by: Mathias Réus <93187038+AwePhD@users.noreply.github.com>
Co-authored-by: Jinhyung Park <jinhyun1@andrew.cmu.edu>
Co-authored-by: Aaron Sun <aaronzs@users.noreply.github.com>
Co-authored-by: LRJKD <101466907+LRJKD@users.noreply.github.com>
Co-authored-by: Haian Huang(深度眸) <1286304229@qq.com>
Co-authored-by: Lei Lei <18294546+Crescent-Saturn@users.noreply.github.com>
Co-authored-by: Leaf Ying <43506966+guyleaf@users.noreply.github.com>
Co-authored-by: key <30455795+keyhsw@users.noreply.github.com>
Co-authored-by: Cycyes <92714336+Cycyes@users.noreply.github.com>
Co-authored-by: Shilin Xu <xsl.cmd@gmail.com>
Co-authored-by: takuoko <to78314910@gmail.com>
Co-authored-by: Jaewoo Choi <130287161+honeybadger78@users.noreply.github.com>
Co-authored-by: Lintch <44701395+returnL@users.noreply.github.com>
Co-authored-by: ilcopione <109541948+ilcopione@users.noreply.github.com>
Co-authored-by: Adnan Mujagic <adnanmujagic@outlook.com>
Co-authored-by: R-Fehler <36566250+R-Fehler@users.noreply.github.com>
Co-authored-by: Jun0922 <89365607+Jun0922@users.noreply.github.com>
Co-authored-by: RangiLyu <lyuchqi@gmail.com>
Co-authored-by: Chen Qibo <69334887+Baboom-l@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhaAndroid hhaAndroid hhaAndroid approved these changes

Assignees

@jbwang1997 jbwang1997

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guyleaf @hhaAndroid @jbwang1997