Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: add Chinese version of config doc #5558

Merged
merged 6 commits into from
Jul 27, 2021

Conversation

BIGWangYuDong
Copy link
Collaborator

This PR adds a Chinese version of the config tutorial.

docs_zh-CN/tutorials/config.md Outdated Show resolved Hide resolved
docs_zh-CN/tutorials/config.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #5558 (b4b7bc9) into master (b6f4366) will increase coverage by 1.11%.
The diff coverage is 64.45%.

❗ Current head b4b7bc9 differs from pull request most recent head f5f8a79. Consider uploading reports for the commit f5f8a79 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5558      +/-   ##
==========================================
+ Coverage   65.25%   66.36%   +1.11%     
==========================================
  Files         276      279       +3     
  Lines       21528    21962     +434     
  Branches     3560     3650      +90     
==========================================
+ Hits        14048    14576     +528     
+ Misses       6727     6632      -95     
- Partials      753      754       +1     
Flag Coverage Δ
unittests 66.36% <64.45%> (+1.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/core/export/pytorch2onnx.py 14.03% <ø> (ø)
mmdet/core/post_processing/bbox_nms.py 80.59% <0.00%> (ø)
mmdet/datasets/pipelines/instaboost.py 15.00% <ø> (ø)
mmdet/models/dense_heads/anchor_head.py 86.72% <ø> (ø)
mmdet/models/dense_heads/cascade_rpn_head.py 22.71% <0.00%> (ø)
mmdet/models/dense_heads/ga_rpn_head.py 22.61% <0.00%> (-0.28%) ⬇️
mmdet/models/roi_heads/mask_heads/fcn_mask_head.py 70.34% <0.00%> (+0.58%) ⬆️
mmdet/models/roi_heads/standard_roi_head.py 65.21% <ø> (+14.90%) ⬆️
mmdet/datasets/pipelines/loading.py 50.64% <16.27%> (-7.78%) ⬇️
mmdet/models/detectors/detr.py 45.45% <25.00%> (-11.69%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f4366...f5f8a79. Read the comment docs.

@jshilong jshilong requested a review from hhaAndroid July 7, 2021 11:56
Copy link
Contributor

@AronLin AronLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the space again. Some comments are just suggestions, you can decide to change or not to change according to your own thought.

docs_zh-CN/tutorials/config.md Outdated Show resolved Hide resolved
docs_zh-CN/tutorials/config.md Outdated Show resolved Hide resolved
docs_zh-CN/tutorials/config.md Outdated Show resolved Hide resolved
docs_zh-CN/tutorials/config.md Outdated Show resolved Hide resolved
docs_zh-CN/tutorials/config.md Outdated Show resolved Hide resolved
docs_zh-CN/tutorials/config.md Outdated Show resolved Hide resolved
docs_zh-CN/tutorials/config.md Outdated Show resolved Hide resolved
docs_zh-CN/tutorials/config.md Outdated Show resolved Hide resolved
docs_zh-CN/tutorials/config.md Outdated Show resolved Hide resolved
docs_zh-CN/tutorials/config.md Outdated Show resolved Hide resolved
@ZwwWayne
Copy link
Collaborator

kindly ping @BIGWangYuDong

@BIGWangYuDong
Copy link
Collaborator Author

Kindly ping @AronLin

Copy link
Contributor

@AronLin AronLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be approved after fixing these typos.

docs_zh-CN/tutorials/config.md Outdated Show resolved Hide resolved
docs_zh-CN/tutorials/config.md Outdated Show resolved Hide resolved
docs_zh-CN/tutorials/config.md Outdated Show resolved Hide resolved
docs_zh-CN/tutorials/config.md Outdated Show resolved Hide resolved
Copy link
Contributor

@AronLin AronLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs_zh-CN/tutorials/config.md Outdated Show resolved Hide resolved
docs_zh-CN/tutorials/config.md Outdated Show resolved Hide resolved
docs_zh-CN/tutorials/config.md Show resolved Hide resolved
docs_zh-CN/tutorials/config.md Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne merged commit be4466d into open-mmlab:master Jul 27, 2021
@BIGWangYuDong BIGWangYuDong deleted the doc_config_zh branch March 17, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants