Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] replace mmcv's function and modules imported with mmengine's #8594

Merged
merged 15 commits into from
Aug 23, 2022

Conversation

chhluo
Copy link
Collaborator

@chhluo chhluo commented Aug 19, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

  1. use mmengine's Config load_state_dict, FileClient, dump, load_checkpoint and etc.
  2. changes due to Remove runner, parallel, engine and device mmcv#2216, Remove many functions in utils mmcv#2217, Migrate utils from mmcv mmengine#447

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@chhluo chhluo requested a review from RangiLyu August 19, 2022 06:04
@chhluo chhluo changed the title [Fix] import fileio related from mmengine [Fix] Changes made due to mmcv #2216 Aug 20, 2022
@chhluo chhluo requested a review from RangiLyu August 20, 2022 12:50
@chhluo chhluo changed the title [Fix] Changes made due to mmcv #2216 [Fix] replace mmcv's function and modules with mmengine's Aug 20, 2022
@chhluo chhluo changed the title [Fix] replace mmcv's function and modules with mmengine's [Fix] replace mmcv's function and modules imported with mmengine's Aug 20, 2022
@zhouzaida
Copy link
Collaborator

MMCV dev-2.x removes many functions in mmcv/utils and move them to mmengine. More detail can be found at open-mmlab/mmcv#2217 and open-mmlab/mmengine#447.

@hhaAndroid
Copy link
Collaborator

@chhluo Please synchronize the latest mmdet dev-3.x. There is a PR merged, it also needs to be modified.

@chhluo
Copy link
Collaborator Author

chhluo commented Aug 22, 2022

@chhluo Please synchronize the latest mmdet dev-3.x. There is a PR merged, it also needs to be modified.

Done

@ZwwWayne ZwwWayne added this to the 3.0.0rc0 milestone Aug 23, 2022
@ZwwWayne ZwwWayne added the P0 Highest priority label Aug 23, 2022
@ZwwWayne ZwwWayne merged commit d0695e6 into open-mmlab:dev-3.x Aug 23, 2022
@hoseinCode
Copy link

hi what is replace function for mmcv.runner?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Highest priority v-3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants