Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix Faster R-CNN Readme #8803

Merged
merged 5 commits into from
Sep 21, 2022
Merged

[Docs] Fix Faster R-CNN Readme #8803

merged 5 commits into from
Sep 21, 2022

Conversation

sudoAimer
Copy link

Motivation

The Link in Faster R-CNN ReadMe is wrong.

Modification

Fix the link of faster_rcnn_r50_fpn_1x_coco.py to faster_rcnn_r50_fpn_giou_1x_coco.py

@CLAassistant
Copy link

CLAassistant commented Sep 15, 2022

CLA assistant check
All committers have signed the CLA.

@RangiLyu
Copy link
Member

Thanks for your contribution! Please sign the CLA first.
image

@RangiLyu
Copy link
Member

And the lint failed, Please run pip install pre-commit and then run pre-commit run --all-files to fix the lint.

@RangiLyu RangiLyu changed the base branch from master to dev September 15, 2022 11:44
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 64.08% // Head: 64.08% // No change to project coverage 👍

Coverage data is based on head (bd19f63) compared to base (2825598).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #8803   +/-   ##
=======================================
  Coverage   64.08%   64.08%           
=======================================
  Files         361      361           
  Lines       29538    29538           
  Branches     5023     5023           
=======================================
  Hits        18928    18928           
- Misses       9592     9593    +1     
+ Partials     1018     1017    -1     
Flag Coverage Δ
unittests 64.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/core/bbox/samplers/random_sampler.py 75.00% <0.00%> (-5.56%) ⬇️
mmdet/core/bbox/assigners/sim_ota_assigner.py 80.00% <0.00%> (-3.64%) ⬇️
mmdet/datasets/pipelines/transforms.py 75.88% <0.00%> (+0.24%) ⬆️
mmdet/core/post_processing/bbox_nms.py 79.10% <0.00%> (+4.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZwwWayne
Copy link
Collaborator

Hi @sudoAimer ,
Thanks for your kind PR. It seems that there are conflicts between your PR and the targeted branch. Could you solve the conflicts so that we could eventually merge this PR?

You can find more details in the place shown as below:
image

@ZwwWayne ZwwWayne modified the milestones: 2.27.0, 2.26.0 Sep 17, 2022
@ZwwWayne ZwwWayne merged commit 1abe291 into open-mmlab:dev Sep 21, 2022
SakiRinn pushed a commit to SakiRinn/mmdetection-locount that referenced this pull request Mar 17, 2023
* [Docs] Fix Faster R-CNN Readme

* [Docs] Fix Faster R-CNN Readme

* [Docs] Fix Faster R-CNN Readme

* Solve the conflict

Co-authored-by: sudo_Aimer <sudo_aimer@qq.com>
Co-authored-by: Czm369 <1341807343@qq.com>
@OpenMMLab-Assistant005
Copy link

Hi @sudoAimer !First of all, we want to express our gratitude for your significant PR in the MMDet project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants