-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed missing __init__ files #1383
Conversation
* fix init_model * Refine warning message Co-authored-by: Tai-Wang <tab_wang@outlook.com>
open-mmlab#1296) * update mn_train * update * Fix typos Co-authored-by: Tai-Wang <tab_wang@outlook.com>
|
Codecov Report
@@ Coverage Diff @@
## dev #1383 +/- ##
==========================================
- Coverage 51.16% 50.88% -0.28%
==========================================
Files 212 215 +3
Lines 18289 18400 +111
Branches 2980 2991 +11
==========================================
+ Hits 9357 9363 +6
- Misses 8375 8480 +105
Partials 557 557
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
After changing the base to dev, need to merge dev into this branch or merge master into dev
* fix init_model * Refine warning message Co-authored-by: Tai-Wang <tab_wang@outlook.com>
open-mmlab#1296) * update mn_train * update * Fix typos Co-authored-by: Tai-Wang <tab_wang@outlook.com>
Hi @deleomike , |
Dear deleomike, |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
The new v1.0.rc1 update has a bug where there are no init.py files for scannet_utils or waymo_utils. This was mentioned in #1378. Despite scannet_utils or waymo_utils being in the repo, when mmdet3d is pip installed those directories are not picked up. This caused a break in a couple of places including
init_model
andtools/create_dataset.py
Modification
I created init.py files for scannet_utils/ and waymo_utils/ that follow the same conventions as the kitti_utils/init.py file.
BC-breaking (Optional)
This does not break back-stream compatibility.
Use cases (Optional)
No new features
Checklist