Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] NMS for Point RCNN #1418

Merged
merged 2 commits into from
Apr 25, 2022
Merged

[Fix] NMS for Point RCNN #1418

merged 2 commits into from
Apr 25, 2022

Conversation

filaPro
Copy link
Contributor

@filaPro filaPro commented Apr 22, 2022

Motivation

Fix #1409 . Now tests/test_models/test_heads/test_heads.py::test_point_rcnn_rpnhead_getboxes and tests/test_models/test_detectors.py::test_point_rcnn are passed successfully.

BC-breaking (Optional)

No

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #1418 (a2ae474) into dev (023c88b) will increase coverage by 0.02%.
The diff coverage is 10.00%.

@@            Coverage Diff             @@
##              dev    #1418      +/-   ##
==========================================
+ Coverage   51.17%   51.19%   +0.02%     
==========================================
  Files         212      212              
  Lines       18284    18289       +5     
  Branches     2980     2980              
==========================================
+ Hits         9356     9363       +7     
+ Misses       8371     8369       -2     
  Partials      557      557              
Flag Coverage Δ
unittests 51.19% <10.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/dense_heads/point_rpn_head.py 26.79% <10.00%> (-0.23%) ⬇️
mmdet3d/datasets/pipelines/transforms_3d.py 88.26% <0.00%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 023c88b...a2ae474. Read the comment docs.

@ZwwWayne ZwwWayne merged commit eab8cfa into open-mmlab:dev Apr 25, 2022
@filaPro filaPro deleted the fix_point_rcnn branch April 27, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants