Fix NaiveSyncBatchNorm1d and NaiveSyncBatchNorm2d
#1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tai-Wang
approved these changes
Apr 27, 2022
ZwwWayne
reviewed
Apr 28, 2022
ZwwWayne
reviewed
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
NaiveSyncBatchNorm1dandNaiveSyncBatchNorm2din the mmdet3d has two potential bugs.NaiveSyncBatchNorm1ddoes not support the input with shape (N, C), which is not consistent withnn.BatchNorm1dModification
using_distflagis_two_dimto support the shape (N, C),BC-breaking (Optional)
None