Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix coco registry problem #1536

Merged
merged 2 commits into from
Jun 8, 2022
Merged

Conversation

ZCMax
Copy link
Collaborator

@ZCMax ZCMax commented Jun 7, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

fix error: KeyError: 'CocoDataset is not in the dataset registry', more details can be found in #1531.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Member

@Tai-Wang Tai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only need to merge the latest dev to check CI when #1537 is merged.

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #1536 (c2865bc) into dev (be8f653) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##              dev    #1536      +/-   ##
==========================================
- Coverage   50.16%   50.15%   -0.01%     
==========================================
  Files         222      222              
  Lines       19092    19095       +3     
  Branches     3132     3133       +1     
==========================================
+ Hits         9577     9578       +1     
- Misses       8938     8939       +1     
- Partials      577      578       +1     
Flag Coverage Δ
unittests 50.15% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/builder.py 42.42% <33.33%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36a0d19...c2865bc. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 1c72acd into open-mmlab:dev Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants