-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add FCAF3D on ScanNet, S3DIS and SUN RGB-D #1547
Conversation
The BC-breaking part of the PR is separated to #1548. Also build problem And one more thing, the minimal version of |
Hi @filaPro , thanks for your contribution! We have fixed the compatibility problem in #1537 . You can merge the latest dev and resolve conflicts to pass the CI test. |
# Conflicts: # mmdet3d/core/bbox/structures/depth_box3d.py # mmdet3d/models/detectors/__init__.py
Will think, how to skip MinkowskiEngine in the failed test and add test for RotatedIoU3DLoss. |
Codecov Report
@@ Coverage Diff @@
## dev #1547 +/- ##
==========================================
- Coverage 50.16% 49.80% -0.37%
==========================================
Files 223 226 +3
Lines 19104 19453 +349
Branches 3134 3174 +40
==========================================
+ Hits 9584 9689 +105
- Misses 8940 9177 +237
- Partials 580 587 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Removed |
Almost ready to merge. Just need to fix the minor comments. |
Motivation
Close #1219. Add FCAF3DNeckWithHead, MinkSingleStage3DDetector and RotatedIoU3DLoss. For all 3 datasets the original authors' checkpoints show exactly the same metrics. Benchmark can be added in the next PR.
Modification
Add FCAF3DHead, MinkSingleStage3DDetector and RotatedIoU3DLoss.
BC-breaking (Optional)
FixDepthInstance3DBoxes.overlaps
.BC-breaking part is merged in #1548.No.