Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix add_mim_extension typo in setup.py #1574

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

ZCMax
Copy link
Collaborator

@ZCMax ZCMax commented Jun 21, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

fix add_mim_extension typo in setup.py

Modification

fix add_mim_extension typo in setup.py

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #1574 (693a212) into dev (42ee0e7) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1574      +/-   ##
==========================================
- Coverage   50.19%   50.16%   -0.04%     
==========================================
  Files         223      223              
  Lines       19104    19104              
  Branches     3134     3134              
==========================================
- Hits         9590     9584       -6     
- Misses       8935     8941       +6     
  Partials      579      579              
Flag Coverage Δ
unittests 50.16% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/pipelines/transforms_3d.py 87.39% <0.00%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42ee0e7...693a212. Read the comment docs.

@ZwwWayne ZwwWayne merged commit de376b6 into open-mmlab:dev Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants