Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add pipelines for BEVDet #1580

Merged
merged 6 commits into from
Jun 29, 2022
Merged

[Feature] Add pipelines for BEVDet #1580

merged 6 commits into from
Jun 29, 2022

Conversation

HuangJunJie2017
Copy link

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Update the transformation in mmdet3d to support requirements in the multi-camera 3D object detection

Modification

  1. Support multi-view wrapper to wrap the transformation designed for single-view situation into multi-view situation.
  2. Support random rotation and return the rotation angle.
  3. Support random crops with a limited range and return the cropping ROI.

BC-breaking (Optional)

--

Use cases (Optional)

--

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues. Done
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness. Done
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects. Not clear and help want.
  4. The documentation has been modified accordingly, like docstring or example tutorials. Has not yet

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2022

CLA assistant check
All committers have signed the CLA.

@Tai-Wang Tai-Wang changed the title Bevdet pipeline [Feature] Add pipelines for BEVDet Jun 24, 2022
Copy link
Member

@Tai-Wang Tai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix minor comments. Others LGTM

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #1580 (dfc19fe) into master (bb20469) will increase coverage by 0.09%.
The diff coverage is 74.68%.

@@            Coverage Diff             @@
##           master    #1580      +/-   ##
==========================================
+ Coverage   50.16%   50.26%   +0.09%     
==========================================
  Files         223      223              
  Lines       19104    19182      +78     
  Branches     3134     3153      +19     
==========================================
+ Hits         9584     9642      +58     
- Misses       8940     8959      +19     
- Partials      580      581       +1     
Flag Coverage Δ
unittests 50.26% <74.68%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/__init__.py 100.00% <ø> (ø)
mmdet3d/datasets/pipelines/__init__.py 100.00% <ø> (ø)
mmdet3d/datasets/pipelines/transforms_3d.py 86.08% <74.68%> (-1.32%) ⬇️
mmdet3d/datasets/pipelines/test_time_aug.py 51.04% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb20469...dfc19fe. Read the comment docs.

@ZwwWayne ZwwWayne merged commit eb5a5a2 into open-mmlab:master Jun 29, 2022
VVsssssk pushed a commit to VVsssssk/mmdetection3d that referenced this pull request Sep 14, 2022
* Initial commit for bevdet modification in the pipeline aspect

* add introduction for MultiViewWrapper

* formatting the introductions

* support multiple transformations in the multi-view wrapper

* Minor fix

* fix some names and support transforming all-fields object in multi-view wrapper

Co-authored-by: Tai-Wang <tab_wang@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants