Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix the error of data type in waymo metric #2109

Merged

Conversation

JingweiZhang12
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Now, after evaluation on Waymo, the type of results is dict(dict). It's not supported in MMEngine. It should be a dict.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 45.28% // Head: 45.28% // No change to project coverage 👍

Coverage data is based on head (19c7715) compared to base (d7067e4).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #2109   +/-   ##
========================================
  Coverage    45.28%   45.28%           
========================================
  Files          255      255           
  Lines        20825    20825           
  Branches      3289     3289           
========================================
  Hits          9431     9431           
  Misses       10774    10774           
  Partials       620      620           
Flag Coverage Δ
unittests 45.28% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/evaluation/metrics/waymo_metric.py 8.14% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JingweiZhang12 JingweiZhang12 requested a review from ZCMax December 7, 2022 07:26
@ZwwWayne ZwwWayne merged commit 65e2074 into open-mmlab:dev-1.x Dec 9, 2022
@JingweiZhang12 JingweiZhang12 deleted the fix_waymo_metrics_collect branch January 11, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants