Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix the bug of counting ignore index in IOU in seg_eval #2229

Merged
merged 5 commits into from
Jan 29, 2023

Conversation

xizaoqu
Copy link
Contributor

@xizaoqu xizaoqu commented Jan 18, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

seg_eval.py will don't filter out ignore index when counting mIOU. This bug is because it assumes that predictions will not include ignore_index.

Modification

Set IOU with ignore_index as nan to filter it out.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ZwwWayne ZwwWayne merged commit e1f695d into open-mmlab:dev-1.x Jan 29, 2023
xizaoqu added a commit to xizaoqu/mmdetection3d that referenced this pull request Feb 8, 2023
@jason102811
Copy link

Dear xizaoqu,
First of all, we want to express our gratitude for your significant PR in the MMDet project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
As a valued contributor, we would also like to invite you to join our Special Interest Group (SIG) private channel, where you can share your experiences, ideas, and build connections with like-minded peers.
Join us :https://discord.gg/raweFPmdzG
To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. We look forward to seeing you there!
Also,if you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx,or scan the following QR code to join us. Please add "mmsig + Github ID" as a remark when adding friends:)
Best regards! @xizaoqu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants