Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support PolarMix augmentation #2265

Merged
merged 24 commits into from
Feb 23, 2023

Conversation

Xiangxu-0103
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 47.09% // Head: 46.96% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (3e32592) compared to base (6318a11).
Patch coverage: 38.01% of modified lines in pull request are covered.

❗ Current head 3e32592 differs from pull request most recent head 6a80afd. Consider uploading reports for the commit 6a80afd to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2265      +/-   ##
===========================================
- Coverage    47.09%   46.96%   -0.14%     
===========================================
  Files          261      262       +1     
  Lines        21679    21964     +285     
  Branches      3425     3460      +35     
===========================================
+ Hits         10210    10315     +105     
- Misses       10816    10987     +171     
- Partials       653      662       +9     
Flag Coverage Δ
unittests 46.96% <38.01%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/transforms/__init__.py 100.00% <ø> (ø)
mmdet3d/models/backbones/mink_resnet.py 25.00% <ø> (ø)
mmdet3d/models/dense_heads/fcaf3d_head.py 16.23% <ø> (ø)
mmdet3d/models/detectors/mink_single_stage.py 43.58% <ø> (ø)
mmdet3d/models/voxel_encoders/voxel_encoder.py 38.46% <6.94%> (-12.08%) ⬇️
...t3d/models/data_preprocessors/data_preprocessor.py 39.10% <17.24%> (-5.05%) ⬇️
mmdet3d/models/data_preprocessors/voxelize.py 33.92% <33.92%> (ø)
mmdet3d/datasets/seg3d_dataset.py 68.08% <66.66%> (-0.10%) ⬇️
mmdet3d/datasets/transforms/transforms_3d.py 36.80% <80.55%> (+3.47%) ⬆️
mmdet3d/models/voxel_encoders/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZwwWayne ZwwWayne merged commit 60d848b into open-mmlab:dev-1.x Feb 23, 2023
@Xiangxu-0103 Xiangxu-0103 deleted the support_polarmix branch March 6, 2023 11:00
xizaoqu pushed a commit to xizaoqu/mmdetection3d that referenced this pull request Mar 15, 2023
* support polarmix

* Update __init__.py

* add UT

* use `BasePoints` instead of numpy

* Update transforms_3d.py

* Update transforms_3d.py

* Update test_transforms_3d.py

* update docs

* update polarmix without MultiImageMixDataset

* add comments

* fix UT

* update docstring

* fix yaw calculation

* fix UT

* refactor

* update

* update docs

* fix typo

* Update transforms_3d.py

* update ut

* fix typehint

* add prob argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants