Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add inferencer for lidar-based segmentation #2304

Merged
merged 12 commits into from
Mar 20, 2023

Conversation

Xiangxu-0103
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Patch coverage: 59.11% and project coverage change: +0.58 🎉

Comparison is base (d84e081) 46.37% compared to head (229272e) 46.95%.

❗ Current head 229272e differs from pull request most recent head 007a1db. Consider uploading reports for the commit 007a1db to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2304      +/-   ##
===========================================
+ Coverage    46.37%   46.95%   +0.58%     
===========================================
  Files          259      265       +6     
  Lines        21390    22263     +873     
  Branches      3379     3497     +118     
===========================================
+ Hits          9919    10453     +534     
- Misses       10827    11141     +314     
- Partials       644      669      +25     
Flag Coverage Δ
unittests 46.95% <59.11%> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/s3dis_dataset.py 78.08% <ø> (ø)
mmdet3d/datasets/scannet_dataset.py 82.75% <ø> (ø)
mmdet3d/datasets/transforms/__init__.py 100.00% <ø> (ø)
mmdet3d/datasets/waymo_dataset.py 17.72% <ø> (ø)
mmdet3d/evaluation/__init__.py 100.00% <ø> (ø)
...tion/functional/waymo_utils/prediction_to_waymo.py 0.00% <0.00%> (ø)
mmdet3d/evaluation/metrics/seg_metric.py 62.50% <0.00%> (ø)
mmdet3d/evaluation/metrics/waymo_metric.py 8.11% <ø> (ø)
mmdet3d/models/dense_heads/centerpoint_head.py 21.77% <0.00%> (ø)
mmdet3d/models/dense_heads/fcaf3d_head.py 16.23% <ø> (ø)
... and 54 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Xiangxu-0103 Xiangxu-0103 requested a review from ZCMax February 28, 2023 12:11
@Xiangxu-0103 Xiangxu-0103 force-pushed the inferencer_lidar_seg branch from 9629d0d to 86612c5 Compare March 8, 2023 09:01
@ZwwWayne ZwwWayne merged commit ef13e5a into open-mmlab:dev-1.x Mar 20, 2023
@Xiangxu-0103 Xiangxu-0103 deleted the inferencer_lidar_seg branch March 22, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants