Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix demo and visualization #2453

Merged
merged 6 commits into from
Apr 25, 2023

Conversation

JingweiZhang12
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 42.68% and no project coverage change.

Comparison is base (aa10365) 46.99% compared to head (d2b71bd) 46.99%.

❗ Current head d2b71bd differs from pull request most recent head f58a690. Consider uploading reports for the commit f58a690 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #2453   +/-   ##
========================================
  Coverage    46.99%   46.99%           
========================================
  Files          275      276    +1     
  Lines        22904    22946   +42     
  Branches      3566     3580   +14     
========================================
+ Hits         10763    10784   +21     
- Misses       11455    11479   +24     
+ Partials       686      683    -3     
Flag Coverage Δ
unittests 46.99% <42.68%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/apis/inference.py 14.45% <0.00%> (-0.18%) ⬇️
mmdet3d/datasets/transforms/loading.py 44.91% <ø> (ø)
mmdet3d/models/segmentors/cylinder3d.py 46.66% <0.00%> (ø)
mmdet3d/models/segmentors/encoder_decoder.py 22.22% <0.00%> (-0.36%) ⬇️
mmdet3d/visualization/local_visualizer.py 33.44% <0.00%> (-0.23%) ⬇️
mmdet3d/models/segmentors/base.py 60.78% <20.00%> (-0.76%) ⬇️
mmdet3d/models/segmentors/minkunet.py 39.39% <20.00%> (-1.24%) ⬇️
mmdet3d/engine/hooks/visualization_hook.py 58.02% <37.50%> (-11.84%) ⬇️
mmdet3d/models/segmentors/seg3d_tta.py 40.00% <40.00%> (ø)
mmdet3d/datasets/transforms/formating.py 58.33% <88.88%> (+3.63%) ⬆️
... and 2 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

README.md Show resolved Hide resolved
configs/pointnet2/README.md Outdated Show resolved Hide resolved
docs/en/advanced_guides/datasets/scannet.md Outdated Show resolved Hide resolved
docs/en/notes/compatibility.md Outdated Show resolved Hide resolved
docs/en/notes/compatibility.md Outdated Show resolved Hide resolved
docs/en/notes/changelog_v1.0.x.md Outdated Show resolved Hide resolved
docs/zh_cn/model_zoo.md Outdated Show resolved Hide resolved
mmdet3d/engine/hooks/visualization_hook.py Outdated Show resolved Hide resolved
mmdet3d/engine/hooks/visualization_hook.py Outdated Show resolved Hide resolved
@JingweiZhang12 JingweiZhang12 merged commit 5ea7fa1 into open-mmlab:dev-1.x Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants