Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix compiling error on windows #766

Merged
merged 2 commits into from
Aug 5, 2021

Conversation

wangruohui
Copy link
Member

@wangruohui wangruohui commented Jul 19, 2021

Fix #169, related to #551 , but the author does not respond.

@CLAassistant
Copy link

CLAassistant commented Jul 19, 2021

CLA assistant check
All committers have signed the CLA.

@Wuziyi616
Copy link
Contributor

@wangruohui Seems that we can successfully build these ops, but will cause errors when importing them. Can you successfully train models using these modified ops in your Linux server?

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #766 (6e5725f) into master (78f4562) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #766   +/-   ##
=======================================
  Coverage   48.97%   48.97%           
=======================================
  Files         208      208           
  Lines       15852    15852           
  Branches     2532     2532           
=======================================
  Hits         7763     7763           
  Misses       7591     7591           
  Partials      498      498           
Flag Coverage Δ
unittests 48.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78f4562...6e5725f. Read the comment docs.

@Wuziyi616
Copy link
Contributor

Hi @wangruohui, can you try re-training one model which uses these ops to benchmark the result? For example, PartA2Net that uses iou3d. If you have trouble downloading the data, I can train it for you.

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Aug 3, 2021

Hi @wangruohui, can you try re-training one model which uses these ops to benchmark the result? For example, PartA2Net that uses iou3d. If you have trouble downloading the data, I can train it for you.

Please train one with this PR. Actually, if the related model can test well, we can merge that. The modification should be fine.

Copy link
Contributor

@Wuziyi616 Wuziyi616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested PointPillars on KITTI, PartA2 on KITTI, VoteNet on ScanNet and PAConv on S3DIS. They cover all the modified CUDA files in this PR. The test accuracy is good.

@wangruohui
Copy link
Member Author

Thank you very much!

@ZwwWayne ZwwWayne merged commit a800db2 into open-mmlab:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compilation error C2131: expression did not evaluate to a constant
4 participants