-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix compiling error on windows #766
Conversation
@wangruohui Seems that we can successfully build these ops, but will cause errors when importing them. Can you successfully train models using these modified ops in your Linux server? |
Codecov Report
@@ Coverage Diff @@
## master #766 +/- ##
=======================================
Coverage 48.97% 48.97%
=======================================
Files 208 208
Lines 15852 15852
Branches 2532 2532
=======================================
Hits 7763 7763
Misses 7591 7591
Partials 498 498
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Hi @wangruohui, can you try re-training one model which uses these ops to benchmark the result? For example, |
Please train one with this PR. Actually, if the related model can test well, we can merge that. The modification should be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have tested PointPillars on KITTI, PartA2 on KITTI, VoteNet on ScanNet and PAConv on S3DIS. They cover all the modified CUDA files in this PR. The test accuracy is good.
Thank you very much! |
Fix #169, related to #551 , but the author does not respond.