Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Migrate to PointSample and enhance PointSample function #840

Merged
merged 7 commits into from
Aug 5, 2021

Conversation

Wuziyi616
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

IndoorPointSample is deprecated in favor of PointSample, so I replace them in the codebase. Also, there is a bug in PointSample now.

Modification

Replace IndoorPointSample with PointSample and fix a bug.

BC-breaking (Optional)

No

Use cases (Optional)

N.A

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@Wuziyi616 Wuziyi616 requested a review from wHao-Wu August 5, 2021 08:58
Copy link
Contributor Author

@Wuziyi616 Wuziyi616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please @wHao-Wu kindly have a look at this PR

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #840 (a521fd1) into master (fc9e0d9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #840   +/-   ##
=======================================
  Coverage   49.18%   49.19%           
=======================================
  Files         210      210           
  Lines       15986    15989    +3     
  Branches     2552     2553    +1     
=======================================
+ Hits         7862     7865    +3     
  Misses       7625     7625           
  Partials      499      499           
Flag Coverage Δ
unittests 49.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/pipelines/transforms_3d.py 90.46% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc9e0d9...a521fd1. Read the comment docs.

@ZwwWayne ZwwWayne merged commit fef04cc into open-mmlab:master Aug 5, 2021
@Wuziyi616 Wuziyi616 deleted the point_sample_trans branch August 8, 2021 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants