-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add shelf and campus datasets #1225
Conversation
Codecov Report
@@ Coverage Diff @@
## dev-0.25 #1225 +/- ##
============================================
+ Coverage 83.44% 84.04% +0.60%
============================================
Files 205 214 +9
Lines 16625 17507 +882
Branches 2976 3115 +139
============================================
+ Hits 13872 14714 +842
- Misses 2001 2012 +11
- Partials 752 781 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Please add unit tests. |
mmpose/datasets/datasets/body3d/body3d_mview_direct_campus_dataset.py
Outdated
Show resolved
Hide resolved
mmpose/datasets/datasets/body3d/body3d_mview_direct_campus_dataset.py
Outdated
Show resolved
Hide resolved
.../body/3d_kpt_mview_rgb_img/voxelpose/campus/voxelpose_prn32x32x32_cpn80x80x20_campus_cam3.py
Show resolved
Hide resolved
.../body/3d_kpt_mview_rgb_img/voxelpose/campus/voxelpose_prn32x32x32_cpn80x80x20_campus_cam3.py
Show resolved
Hide resolved
mmpose/datasets/datasets/base/kpt_3d_mview_rgb_img_direct_dataset.py
Outdated
Show resolved
Hide resolved
mmpose/datasets/datasets/body3d/body3d_mview_direct_shelf_dataset.py
Outdated
Show resolved
Hide resolved
mmpose/datasets/datasets/body3d/body3d_mview_direct_campus_dataset.py
Outdated
Show resolved
Hide resolved
* [Feature] Add shelf and campus datasets * fix config typo * Add unittests for dataset and pipeline and modify configs * unittest for dataset * add more unittests for pose3d_transform * move several general functions to base class * add related docs for campus and shelf dataset * modify config for campus * fix typo * fix some docs * remove _get_db method in base class * update log path * fix log path * add more descriptions in configs * keep _get_db method in base class and add error message in subclasses * add explanation of some functions * add explanation about dataset in doc string * modify the path for train_pose_db_file in config and docs * add code license of the dataset
* [Feature] Add shelf and campus datasets * fix config typo * Add unittests for dataset and pipeline and modify configs * unittest for dataset * add more unittests for pose3d_transform * move several general functions to base class * add related docs for campus and shelf dataset * modify config for campus * fix typo * fix some docs * remove _get_db method in base class * update log path * fix log path * add more descriptions in configs * keep _get_db method in base class and add error message in subclasses * add explanation of some functions * add explanation about dataset in doc string * modify the path for train_pose_db_file in config and docs * add code license of the dataset
* [Feature] Add shelf and campus datasets * fix config typo * Add unittests for dataset and pipeline and modify configs * unittest for dataset * add more unittests for pose3d_transform * move several general functions to base class * add related docs for campus and shelf dataset * modify config for campus * fix typo * fix some docs * remove _get_db method in base class * update log path * fix log path * add more descriptions in configs * keep _get_db method in base class and add error message in subclasses * add explanation of some functions * add explanation about dataset in doc string * modify the path for train_pose_db_file in config and docs * add code license of the dataset
* [Feature] Add shelf and campus datasets * fix config typo * Add unittests for dataset and pipeline and modify configs * unittest for dataset * add more unittests for pose3d_transform * move several general functions to base class * add related docs for campus and shelf dataset * modify config for campus * fix typo * fix some docs * remove _get_db method in base class * update log path * fix log path * add more descriptions in configs * keep _get_db method in base class and add error message in subclasses * add explanation of some functions * add explanation about dataset in doc string * modify the path for train_pose_db_file in config and docs * add code license of the dataset
Motivation
Add shelf and campus datasets for multi-view 3D pose task.
Modification
Add dataset info in
configs/_base_/datasets/campus.py
andconfigs/_base_/datasets/shelf.py
.Modified base class
Kpt3dMviewRgbImgDirectDataset
inmmpose/datasets/datasets/base/kpt_3d_mview_rgb_img_direct_dataset.py
.Add
Body3DMviewDirectCampusDataset
inmmpose/datasets/datasets/body3d/body3d_mview_direct_campus_dataset.py
andBody3DMviewDirectShelfDataset
mmpose/datasets/datasets/body3d/body3d_mview_direct_shelf_dataset.py
, modified related__init__.py
.Add related config files under
configs/body/3d_kpt_mview_rgb_img/voxelpose/campus/
andconfigs/body/3d_kpt_mview_rgb_img/voxelpose/shelf/
.Add
pcp
metric inmmpose/core/evaluation/eval_hooks.py
.Add related data transforms in
mmpose/datasets/pipelines/pose3d_transform.py
.BC-breaking (Optional)
Use cases (Optional)
Checklist
Before PR:
After PR: