Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add shelf and campus datasets #1225

Merged
merged 19 commits into from
Apr 1, 2022

Conversation

liqikai9
Copy link
Collaborator

@liqikai9 liqikai9 commented Mar 8, 2022

Motivation

Add shelf and campus datasets for multi-view 3D pose task.

Modification

  1. Add dataset info in configs/_base_/datasets/campus.py and configs/_base_/datasets/shelf.py.

  2. Modified base class Kpt3dMviewRgbImgDirectDataset in mmpose/datasets/datasets/base/kpt_3d_mview_rgb_img_direct_dataset.py.
    Add Body3DMviewDirectCampusDataset in mmpose/datasets/datasets/body3d/body3d_mview_direct_campus_dataset.py and Body3DMviewDirectShelfDataset mmpose/datasets/datasets/body3d/body3d_mview_direct_shelf_dataset.py, modified related __init__.py.

  3. Add related config files under configs/body/3d_kpt_mview_rgb_img/voxelpose/campus/ and configs/body/3d_kpt_mview_rgb_img/voxelpose/shelf/.

  4. Add pcp metric in mmpose/core/evaluation/eval_hooks.py.

  5. Add related data transforms in mmpose/datasets/pipelines/pose3d_transform.py.

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #1225 (2f7a37f) into dev-0.25 (c09a693) will increase coverage by 0.60%.
The diff coverage is 91.85%.

@@             Coverage Diff              @@
##           dev-0.25    #1225      +/-   ##
============================================
+ Coverage     83.44%   84.04%   +0.60%     
============================================
  Files           205      214       +9     
  Lines         16625    17507     +882     
  Branches       2976     3115     +139     
============================================
+ Hits          13872    14714     +842     
- Misses         2001     2012      +11     
- Partials        752      781      +29     
Flag Coverage Δ
unittests 83.98% <91.85%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/core/evaluation/eval_hooks.py 78.12% <ø> (ø)
mmpose/datasets/__init__.py 100.00% <ø> (ø)
...ets/body3d/body3d_mview_direct_panoptic_dataset.py 81.81% <ø> (+0.44%) ⬆️
mmpose/datasets/pipelines/pose3d_transform.py 83.95% <80.00%> (+8.61%) ⬆️
...asets/body3d/body3d_mview_direct_campus_dataset.py 93.12% <93.12%> (ø)
...tasets/body3d/body3d_mview_direct_shelf_dataset.py 94.57% <94.57%> (ø)
...tasets/base/kpt_3d_mview_rgb_img_direct_dataset.py 80.74% <95.52%> (+14.07%) ⬆️
mmpose/datasets/datasets/__init__.py 100.00% <100.00%> (ø)
mmpose/datasets/datasets/body3d/__init__.py 100.00% <100.00%> (ø)
mmpose/datasets/builder.py 78.94% <0.00%> (-0.79%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c09a693...2f7a37f. Read the comment docs.

@liqikai9 liqikai9 requested a review from wusize March 8, 2022 10:08
@liqikai9 liqikai9 changed the base branch from master to dev-0.25 March 8, 2022 10:33
@ly015
Copy link
Member

ly015 commented Mar 11, 2022

Please add unit tests.

@ly015 ly015 merged commit 585df59 into open-mmlab:dev-0.25 Apr 1, 2022
ly015 pushed a commit that referenced this pull request Apr 2, 2022
* [Feature] Add shelf and campus datasets

* fix config typo

* Add unittests for dataset and pipeline and modify configs

* unittest for dataset

* add more unittests for pose3d_transform

* move several general functions to base class

* add related docs for campus and shelf dataset

* modify config for campus

* fix typo

* fix some docs

* remove _get_db method in base class

* update log path

* fix log path

* add more descriptions in configs

* keep _get_db method in base class and add error message in subclasses

* add explanation of some functions

* add explanation about dataset in doc string

* modify the path for train_pose_db_file in config and docs

* add code license of the dataset
ly015 pushed a commit that referenced this pull request Apr 2, 2022
* [Feature] Add shelf and campus datasets

* fix config typo

* Add unittests for dataset and pipeline and modify configs

* unittest for dataset

* add more unittests for pose3d_transform

* move several general functions to base class

* add related docs for campus and shelf dataset

* modify config for campus

* fix typo

* fix some docs

* remove _get_db method in base class

* update log path

* fix log path

* add more descriptions in configs

* keep _get_db method in base class and add error message in subclasses

* add explanation of some functions

* add explanation about dataset in doc string

* modify the path for train_pose_db_file in config and docs

* add code license of the dataset
@liqikai9 liqikai9 deleted the campus_and_shelf_dataset branch September 18, 2022 07:59
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* [Feature] Add shelf and campus datasets

* fix config typo

* Add unittests for dataset and pipeline and modify configs

* unittest for dataset

* add more unittests for pose3d_transform

* move several general functions to base class

* add related docs for campus and shelf dataset

* modify config for campus

* fix typo

* fix some docs

* remove _get_db method in base class

* update log path

* fix log path

* add more descriptions in configs

* keep _get_db method in base class and add error message in subclasses

* add explanation of some functions

* add explanation about dataset in doc string

* modify the path for train_pose_db_file in config and docs

* add code license of the dataset
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* [Feature] Add shelf and campus datasets

* fix config typo

* Add unittests for dataset and pipeline and modify configs

* unittest for dataset

* add more unittests for pose3d_transform

* move several general functions to base class

* add related docs for campus and shelf dataset

* modify config for campus

* fix typo

* fix some docs

* remove _get_db method in base class

* update log path

* fix log path

* add more descriptions in configs

* keep _get_db method in base class and add error message in subclasses

* add explanation of some functions

* add explanation about dataset in doc string

* modify the path for train_pose_db_file in config and docs

* add code license of the dataset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants