-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] skip joints that should be hidden in visualization #1228
Conversation
just noticed, that the same would happen with the 3d version, you may want to look at that too. |
Codecov Report
@@ Coverage Diff @@
## dev-0.25 #1228 +/- ##
============================================
- Coverage 83.44% 83.43% -0.01%
============================================
Files 205 205
Lines 16625 16629 +4
Branches 2976 2976
============================================
+ Hits 13872 13875 +3
- Misses 2001 2002 +1
Partials 752 752
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Yining Li <liyining0712@gmail.com>
Co-authored-by: Yining Li <liyining0712@gmail.com>
…n the edge of the image
fixed the test |
…1228) * don't visualize joints/skeleton parts that are marked as hidden * pre-commit changes * adjust test case * simplification Co-authored-by: Yining Li <liyining0712@gmail.com> * simplification Co-authored-by: Yining Li <liyining0712@gmail.com> * add back vars deleted by mistake, don't draw link when one joint is on the edge of the image * split test_imshow_keypoints into 2d and 3d Co-authored-by: Yining Li <liyining0712@gmail.com>
* don't visualize joints/skeleton parts that are marked as hidden * pre-commit changes * adjust test case * simplification Co-authored-by: Yining Li <liyining0712@gmail.com> * simplification Co-authored-by: Yining Li <liyining0712@gmail.com> * add back vars deleted by mistake, don't draw link when one joint is on the edge of the image * split test_imshow_keypoints into 2d and 3d Co-authored-by: Yining Li <liyining0712@gmail.com>
Hi @womeier!First of all, we want to express our gratitude for your significant PR in the MMPose project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR. We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) |
…1228) * don't visualize joints/skeleton parts that are marked as hidden * pre-commit changes * adjust test case * simplification Co-authored-by: Yining Li <liyining0712@gmail.com> * simplification Co-authored-by: Yining Li <liyining0712@gmail.com> * add back vars deleted by mistake, don't draw link when one joint is on the edge of the image * split test_imshow_keypoints into 2d and 3d Co-authored-by: Yining Li <liyining0712@gmail.com>
…1228) * don't visualize joints/skeleton parts that are marked as hidden * pre-commit changes * adjust test case * simplification Co-authored-by: Yining Li <liyining0712@gmail.com> * simplification Co-authored-by: Yining Li <liyining0712@gmail.com> * add back vars deleted by mistake, don't draw link when one joint is on the edge of the image * split test_imshow_keypoints into 2d and 3d Co-authored-by: Yining Li <liyining0712@gmail.com>
fix for issue #1227
joints with color=None should be skipped according to the documentation:
mmpose/mmpose/core/visualization/image.py
Line 126 in c09a693