Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] skip joints that should be hidden in visualization #1228

Merged
merged 7 commits into from
Mar 11, 2022
Merged

[Fix] skip joints that should be hidden in visualization #1228

merged 7 commits into from
Mar 11, 2022

Conversation

womeier
Copy link
Contributor

@womeier womeier commented Mar 9, 2022

fix for issue #1227

joints with color=None should be skipped according to the documentation:

pose_kpt_color (np.array[Nx3]`): Color of N keypoints. If None,

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2022

CLA assistant check
All committers have signed the CLA.

@jin-s13 jin-s13 requested a review from ly015 March 9, 2022 07:50
@womeier
Copy link
Contributor Author

womeier commented Mar 9, 2022

just noticed, that the same would happen with the 3d version, you may want to look at that too.

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #1228 (213a499) into dev-0.25 (c09a693) will decrease coverage by 0.00%.
The diff coverage is 84.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev-0.25    #1228      +/-   ##
============================================
- Coverage     83.44%   83.43%   -0.01%     
============================================
  Files           205      205              
  Lines         16625    16629       +4     
  Branches       2976     2976              
============================================
+ Hits          13872    13875       +3     
- Misses         2001     2002       +1     
  Partials        752      752              
Flag Coverage Δ
unittests 83.36% <84.61%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/core/visualization/image.py 67.14% <84.61%> (+0.32%) ⬆️
mmpose/datasets/builder.py 78.94% <0.00%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c09a693...213a499. Read the comment docs.

@ly015 ly015 changed the base branch from master to dev-0.25 March 9, 2022 09:15
@ly015 ly015 changed the title visualization bugfix: skip joints that should be hidden [Fix] skip joints that should be hidden in visualization Mar 9, 2022
womeier and others added 3 commits March 9, 2022 11:42
Co-authored-by: Yining Li <liyining0712@gmail.com>
Co-authored-by: Yining Li <liyining0712@gmail.com>
@womeier womeier marked this pull request as draft March 9, 2022 21:20
@womeier womeier marked this pull request as ready for review March 10, 2022 10:48
@womeier
Copy link
Contributor Author

womeier commented Mar 10, 2022

fixed the test

@ly015 ly015 merged commit 3245faa into open-mmlab:dev-0.25 Mar 11, 2022
liqikai9 pushed a commit to liqikai9/mmpose that referenced this pull request Mar 28, 2022
…1228)

* don't visualize joints/skeleton parts that are marked as hidden

* pre-commit changes

* adjust test case

* simplification

Co-authored-by: Yining Li <liyining0712@gmail.com>

* simplification

Co-authored-by: Yining Li <liyining0712@gmail.com>

* add back vars deleted by mistake, don't draw link when one joint is on the edge of the image

* split test_imshow_keypoints into 2d and 3d

Co-authored-by: Yining Li <liyining0712@gmail.com>
ly015 added a commit that referenced this pull request Apr 2, 2022
* don't visualize joints/skeleton parts that are marked as hidden

* pre-commit changes

* adjust test case

* simplification

Co-authored-by: Yining Li <liyining0712@gmail.com>

* simplification

Co-authored-by: Yining Li <liyining0712@gmail.com>

* add back vars deleted by mistake, don't draw link when one joint is on the edge of the image

* split test_imshow_keypoints into 2d and 3d

Co-authored-by: Yining Li <liyining0712@gmail.com>
@OpenMMLab-Assistant003
Copy link

Hi @womeier!First of all, we want to express our gratitude for your significant PR in the MMPose project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤ @womeier

shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
…1228)

* don't visualize joints/skeleton parts that are marked as hidden

* pre-commit changes

* adjust test case

* simplification

Co-authored-by: Yining Li <liyining0712@gmail.com>

* simplification

Co-authored-by: Yining Li <liyining0712@gmail.com>

* add back vars deleted by mistake, don't draw link when one joint is on the edge of the image

* split test_imshow_keypoints into 2d and 3d

Co-authored-by: Yining Li <liyining0712@gmail.com>
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
…1228)

* don't visualize joints/skeleton parts that are marked as hidden

* pre-commit changes

* adjust test case

* simplification

Co-authored-by: Yining Li <liyining0712@gmail.com>

* simplification

Co-authored-by: Yining Li <liyining0712@gmail.com>

* add back vars deleted by mistake, don't draw link when one joint is on the edge of the image

* split test_imshow_keypoints into 2d and 3d

Co-authored-by: Yining Li <liyining0712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants