Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] complete training hooks. #1236

Merged
merged 2 commits into from
Mar 14, 2022
Merged

[Fix] complete training hooks. #1236

merged 2 commits into from
Mar 14, 2022

Conversation

bladrome
Copy link
Contributor

@bladrome bladrome commented Mar 13, 2022

Motivation

There is no reason to ignore custom_hooks.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Mar 13, 2022

Codecov Report

Merging #1236 (a9a120c) into master (cd067a9) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1236   +/-   ##
=======================================
  Coverage   83.44%   83.44%           
=======================================
  Files         205      205           
  Lines       16625    16625           
  Branches     2976     2976           
=======================================
  Hits        13872    13872           
  Misses       2001     2001           
  Partials      752      752           
Flag Coverage Δ
unittests 83.36% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/apis/train.py 22.53% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f9829e...a9a120c. Read the comment docs.

@ly015 ly015 requested review from ly015 and jin-s13 March 14, 2022 02:52
@ly015 ly015 changed the title Fix: complete training hooks. [Fix] complete training hooks. Mar 14, 2022
@ly015
Copy link
Member

ly015 commented Mar 14, 2022

@bladrome Thank you very much for your help!

I made a minor modification to this PR to not expose timer_config, suggested by mmcv authors.

@ly015 ly015 merged commit 663cfc8 into open-mmlab:master Mar 14, 2022
liqikai9 pushed a commit to liqikai9/mmpose that referenced this pull request Mar 28, 2022
* Fix: complete training hooks.

* not expose timer_hook

Co-authored-by: ly015 <liyining0712@gmail.com>
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* Fix: complete training hooks.

* not expose timer_hook

Co-authored-by: ly015 <liyining0712@gmail.com>
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* Fix: complete training hooks.

* not expose timer_hook

Co-authored-by: ly015 <liyining0712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants