[Feature] Add voxelpose demo #1270

wusize · 2022-03-30T05:44:45Z

Motivation

Add demo/inference for voxelpose

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

CLA has been signed and all committers have signed the CLA in this PR.

CLAassistant · 2022-03-30T05:44:50Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ly015
❌ wusize

wusize seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

codecov · 2022-03-30T10:08:52Z

Codecov Report

Merging #1270 (16667eb) into master (20f7b29) will increase coverage by 0.00%.
The diff coverage is 82.60%.

@@           Coverage Diff           @@
##           master    #1270   +/-   ##
=======================================
  Coverage   83.43%   83.43%           
=======================================
  Files         205      205           
  Lines       16625    16692   +67     
  Branches     2976     2989   +13     
=======================================
+ Hits        13871    13927   +56     
- Misses       2001     2005    +4     
- Partials      753      760    +7

Flag	Coverage Δ
unittests	`83.36% <82.60%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
mmpose/core/visualization/__init__.py	`100.00% <ø> (ø)`
mmpose/models/detectors/multiview_pose.py	`69.57% <73.17%> (+0.53%)`	⬆️
mmpose/core/visualization/image.py	`70.38% <96.42%> (+3.55%)`	⬆️
mmpose/datasets/datasets/hand/rhd2d_dataset.py	`97.18% <0.00%> (+0.04%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 503cd03...16667eb. Read the comment docs.

mmpose/core/visualization/image.py

ly015 · 2022-04-02T04:06:48Z

The image data size is still a little bit large. How about we package the images as a .zip or .tar file and hold it on OSS. We can guide the user to download the data in the markdown doc, or automatically download it in the script.

jin-s13 · 2022-04-02T12:49:53Z

unittest coverage rate should be further improved.

JonathanLehner · 2022-04-02T13:26:55Z

how is it going? can the demo already be used?

jin-s13 · 2022-04-02T13:32:37Z

how is it going? can the demo already be used?

Thanks for your interest! @JonathanLehner

It is still in review, and some modifications are required.
But I think basic functions have been realized. You may have a try!

Also it is very welcome if you could help review this PR. If you have any comments about this PR, please feel free to comment here directly.

JonathanLehner · 2022-04-02T16:32:40Z

Thanks everyone for your great work! It seems you finished now? I will have more time tomorrow, then I can debug

ly015 · 2022-04-02T16:57:52Z

Thanks everyone for your great work! It seems you finished now? I will have more time tomorrow, then I can debug

Thank you very much. This PR has been tested and merged. Welcome to have a try and please leave us an issue if you run into any problems or have any suggestions. We are looking forward to your feedback.

JonathanLehner

looks all good. outside of this PR, I also get this warning: floordiv is deprecated, and its behavior will change in a future version of pytorch. It currently rounds toward 0 (like the 'trunc' function NOT 'floor'). This results in incorrect rounding for negative values. To keep the current behavior, use torch.div(a, b, rounding_mode='trunc'), or for actual floor division, use torch.div(a, b, rounding_mode='floor'). -- that might be good to replace

wusize · 2022-04-04T05:50:59Z

Thank you Jonathan! This warning is raised for operation "a // b" with pytorch version beyond 1.9.0. I will replace it.

* 'inference_for_voxelpose' * 'fix_bug' * 'readme' * fix lint * add auto downlaod * 'unit_test' * 'load_camera_params_from_downloaded_data' * 'add_torch_no_grad' * 'unit_test_show_results' * 'vis_2d_in_unit_test' * 'fix_typo' * fix lint Co-authored-by: wusize <wusize@sensetime.com> Co-authored-by: ly015 <liyining0712@gmail.com>

wusize added 2 commits March 30, 2022 11:55

'inference_for_voxelpose'

a738f9e

'fix_bug'

3eaed32

ly015 changed the title ~~Inference for voxelpose~~ [Feature] Add voxelpose demo Mar 31, 2022

ly015 requested a review from jin-s13 March 31, 2022 03:21

wusize and others added 2 commits March 31, 2022 17:07

'readme'

bb2b14d

fix lint

93cad3f

ly015 reviewed Apr 2, 2022

View reviewed changes

mmpose/core/visualization/image.py Show resolved Hide resolved

ly015 and others added 2 commits April 2, 2022 18:19

add auto downlaod

1e72e94

'unit_test'

49d25bc

wusize added 3 commits April 2, 2022 22:07

'load_camera_params_from_downloaded_data'

960245b

'add_torch_no_grad'

638554e

'unit_test_show_results'

e779181

jin-s13 approved these changes Apr 2, 2022

View reviewed changes

wusize and others added 3 commits April 2, 2022 23:21

'vis_2d_in_unit_test'

9247995

'fix_typo'

6abf366

fix lint

16667eb

ly015 changed the base branch from master to dev-0.25 April 2, 2022 16:33

ly015 changed the base branch from dev-0.25 to master April 2, 2022 16:33

ly015 merged commit 0002f11 into master Apr 2, 2022

JonathanLehner reviewed Apr 4, 2022

View reviewed changes

jin-s13 deleted the inference_for_voxelpose branch April 27, 2022 09:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] Add voxelpose demo #1270

[Feature] Add voxelpose demo #1270

wusize commented Mar 30, 2022

CLAassistant commented Mar 30, 2022 •

edited

Loading

codecov bot commented Mar 30, 2022 •

edited

Loading

ly015 commented Apr 2, 2022

jin-s13 commented Apr 2, 2022

JonathanLehner commented Apr 2, 2022

jin-s13 commented Apr 2, 2022

JonathanLehner commented Apr 2, 2022

ly015 commented Apr 2, 2022

JonathanLehner left a comment

wusize commented Apr 4, 2022

[Feature] Add voxelpose demo #1270

[Feature] Add voxelpose demo #1270

Conversation

wusize commented Mar 30, 2022

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

CLAassistant commented Mar 30, 2022 • edited Loading

codecov bot commented Mar 30, 2022 • edited Loading

Codecov Report

ly015 commented Apr 2, 2022

jin-s13 commented Apr 2, 2022

JonathanLehner commented Apr 2, 2022

jin-s13 commented Apr 2, 2022

JonathanLehner commented Apr 2, 2022

ly015 commented Apr 2, 2022

JonathanLehner left a comment

Choose a reason for hiding this comment

wusize commented Apr 4, 2022

CLAassistant commented Mar 30, 2022 •

edited

Loading

codecov bot commented Mar 30, 2022 •

edited

Loading