btl/openib: enable connecting processes from different subnets. #1043
Conversation
+ Added an mca parameter to allow connecting processes from different subnets. Its current default value is 'false' - don't allow, to keep the current flow the way it is now. + rmdacm: when calling ibv_query_gid, use the gid index from btl_openib_gid_index. from commit bbcbe3c in the master branch.
|
Test PASSed. |
|
@alinask please assign a reviewer and milestone |
|
@hppritcha I don't have permissions to set a milestone.. |
|
@alinask Yeah, it's because of weirdness on Github -- they don't give us fine-grained enough permissions. As a workaround to let devs assign milestones/reviewers, we have the "ompi-bot" who can do these things for you -- see https://github.com/open-mpi/ompi/wiki/OmpiReleaseBotCommands. |
|
@alinask Also, Github pro tip: the bbcbe3c commit isn't known in this repository (because it's on the ompi master, not any of the release branches). So Github doesn't auto-link that commit hash in your description (or comment). But if you prefix that hash with the full repo name, Github will auto-link it. For example: open-mpi/ompi@bbcbe3c. This tells Github that that hash is part of the "ompi" git repo in the "open-mpi" org, and therefore it knows how to auto-link it to the original commit. Make sense? |
|
@jsquyres Thanks! I updated the commit message. |
|
bot:milestone:v2.0.0 |
|
@hppritcha this was already reviewed by @miked-mellanox. Cherry-picked from open-mpi/ompi@bbcbe3c |
|
marking reviewed per earlier @miked-mellanox review on ompi/master |
|
👍 |
|
OMPIBot error: Label "reviewed" is already set on issue 1043. |
|
@rhc54 Please merge. Thanks. |
|
I'm sorry, this is for 2.0.0 - @jsquyres or @hppritcha please merge. |
|
@jsquyres should we try to get this in to 2.0.0? |
|
After some more consideration, I'm reluctant now to accept this in to 2.0.0 at this point. It is really more of a feature than a bug fix. At this point, if a customer needs to use this feature, they can make use of the 1.10.3 release. So I'm scheduling this for the 2.1 feature update. |
|
bot:mellanox:retest |
|
Test PASSed. |
subnets. Its current default value is 'false' - don't allow, to keep the
current flow the way it is now.
btl_openib_gid_index.
from commit open-mpi/ompi@bbcbe3c in the master branch.