Remove openib and affiliated stuff #6270
Conversation
|
@jsquyres oshmem/mca/sshmem/verbs is deprecated. |
|
@yosefe Didn't someone validate that iWARP devices work in UCX? |
|
@yosefe Just to be clear: should I also remove |
|
Just giving my 2 cents here...
|
|
Rats -- we forgot to talk about this today on the 2019-01-15 webex... |
|
@yosefe Just to be clear: should I also remove oshmem/mca/sshmem/verbs as part of this PR? |
|
@jsquyres yes, need to remove also oshmem/mca/sshmem/verbs |
jsquyres
force-pushed
the
pr/remove-openib-and-affiliated-stuff
branch
from
bb6eb54
to
6f3e19a
Compare
|
@yosefe Updated. Could you please check to make sure I didn't break anything in the OSHMEM layer? |
|
bot:ompi:retest |
So long BTL openib! After many years of (mostly) faithful service, it is time to remove the openib BTL. It has been fully replaced by other components, such as the UCX PML and OFI MTL. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
So long sshmem/verbs! After many years of (mostly) faithful service, it is time to remove the sshmem verbs component. It has been fully replaced by other components, such as the UCX PML and OFI MTL. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
jsquyres
force-pushed
the
pr/remove-openib-and-affiliated-stuff
branch
from
6f3e19a
to
9915c30
Compare
The verbs and verbs_usnic components are now no longer necessary / no longer used anywhere in the code base. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Now that all components that use libibverbs are gone, remove OPAL_CHECK_VERBS and the confusingly-named OPAL_CHECK_OPENFABRICS (which really just checked for verbs things -- not all the possible OpenFabrics APIs/libraries). The only code left in Open MPI that calls verbs is hwloc -- and that's just the APIs that takes an IBV device and returns topological information about it. Since nothing in the Open MPI code base uses the "ibv_*" API any more, we have no need for this hwloc functionality so we'll even remove the --with-verbs configure options. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Now that all use of libibverbs is gone from Open MPI, and all verbs-based configury is also removed, update README to remove all references to --with-verbs. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Since --with-verbs has been removed, then remove it from all the platform files, too. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
jsquyres
force-pushed
the
pr/remove-openib-and-affiliated-stuff
branch
from
9915c30
to
99553eb
Compare
Per https://github.com/open-mpi/ompi/wiki/5.0.x-FeatureList, remove the openib BTL.
As a consequence, also:
ibv_fork_checkfunctionality tooshmem/mca/sshmem/verbsopal/mca/common/verbsandopal/mca/common/verbs_usnicNeed to check with Mellanox on the status of
oshmem/mca/sshmem/verbs. If it's still used, we can fold much ofconfig/opal_check_openfabrics.m4andconfig/opal_check_verbs.m4intooshmem/mca/sshmem/verbs. If it's no longer used / deprecated, we can just remove all of that functionality.@hoopoepg @yosefe Can you guys comment on whether
oshmem/mca/sshmem/verbsis still used? I.e., should I fold the verbs configury stuff up intooshmem/mca/sshmem/verbs? Or shouldoshmem/mca/sshmem/verbsgo away, along with all the verbs configury?Fixes #6265.