-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #3146 Support close open/fail for Ready Tracker & surface errors swallowed by grp.Wait() #3308
fix: #3146 Support close open/fail for Ready Tracker & surface errors swallowed by grp.Wait() #3308
Commits on Jul 2, 2024
-
Add error handling & fail-close support in Ready Tracker
Add fail-close support for fetching expectations by adding error handling & surfacing the errors being swallowed by grp.Wait(). Signed-off-by: David-Jaeyoon-Lee <davjlee@google.com>
Configuration menu - View commit details
-
Copy full SHA for 78d01f8 - Browse repository at this point
Copy the full SHA 78d01f8View commit details -
Remove the starting hyphen from the crash-on-failure-fetching-expectations flag Signed-off-by: David-Jaeyoon-Lee <davjlee@google.com>
Configuration menu - View commit details
-
Copy full SHA for 1917366 - Browse repository at this point
Copy the full SHA 1917366View commit details -
Add comment for constraint & data tracker, fix retErr nil comparison,
and add unit tests Fix comments and return error in trackConfigAndSyncSets. Add unit tests for each track method & each wait in Run method. Signed-off-by: David-Jaeyoon-Lee <davjlee@google.com>
Configuration menu - View commit details
-
Copy full SHA for af869f0 - Browse repository at this point
Copy the full SHA af869f0View commit details -
Fix crashOnFailureFetchingExpectations flag description & race condition
in test Signed-off-by: David-Jaeyoon-Lee <davjlee@google.com>
Configuration menu - View commit details
-
Copy full SHA for 5010682 - Browse repository at this point
Copy the full SHA 5010682View commit details -
Remove Errgroup logic from ReadyTracker
Change errgroup logic such that we instead use waitgroups and errchannels. This is that we remove the idea of shared fate between each tracking/subtracking threads. Removes complexity of figuring out what the errgroups are doing as well as complicated logic with shared fate between tracking threads and singlerunners Signed-off-by: David-Jaeyoon-Lee <davjlee@google.com>
Configuration menu - View commit details
-
Copy full SHA for 876b50a - Browse repository at this point
Copy the full SHA 876b50aView commit details -
Removing race condition by giving each fake client its own scheme object
Signed-off-by: David-Jaeyoon-Lee <davjlee@google.com>
Configuration menu - View commit details
-
Copy full SHA for f874270 - Browse repository at this point
Copy the full SHA f874270View commit details
Commits on Jul 12, 2024
-
Change naming of variables, refactor, and lint errors
Signed-off-by: David-Jaeyoon-Lee <davjlee@google.com>
Configuration menu - View commit details
-
Copy full SHA for 212d84c - Browse repository at this point
Copy the full SHA 212d84cView commit details
Commits on Jul 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b1a8531 - Browse repository at this point
Copy the full SHA b1a8531View commit details
Commits on Jul 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 762134e - Browse repository at this point
Copy the full SHA 762134eView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf49b3c - Browse repository at this point
Copy the full SHA bf49b3cView commit details