-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GO version to match OPA version #603
Conversation
@pratimsc I think it would be a good idea to bump the |
@tjons - I have updated the version in go.mod file |
Does it make sense to add a ci check at some point to make sure the toolchain / mod version are the same as in .go-version? |
@nfuden - It will be good idea to put in the check, and also another check to use the same version of Go as the Is the present PR good to merge? |
@pratimsc neither @nfuden nor I are maintainers, I'm just a contributor. cc @ashutosh-narkar to review. |
The OPA Envoy Plugin fails due to CVEs present in G 1.22.5. Update it to Go version used by OPA i.e. 1.23.1, which has the required CVE fixes. List of CVEs: - CVE-2024-34155 - CVE-2024-34156 - CVE-2024-34158 Signed-off-by: Pratim SC <pratimsc@users.noreply.github.com>
Signed-off-by: Pratim SC <pratimsc@users.noreply.github.com>
Updated the version to align with OPA Go min version. Signed-off-by: Pratim SC <pratimsc@users.noreply.github.com>
cd7a294
to
22c831d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The OPA Envoy Plugin fails due to CVEs present in G 1.22.5. Update it to Go version used by OPA i.e. 1.23.1, which has the required CVE fixes.
List of CVEs: