Asserting every domain is an iterable type before evaluation
#6763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: open-policy-agent#6762 Signed-off-by: Johan Fylling <johan.dev@fylling.se>
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
srenatus
reviewed
May 27, 2024
| return e.save(iter) | ||
| } | ||
|
|
||
| domain := e.e.closure(e.generator) | ||
| if pd := e.e.bindings.Plug(e.Domain); pd != nil { |
There was a problem hiding this comment.
Probably never. Sometimes I'm guilty of writing a tad too defensive code 😄.
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
Adding `IsSetStmt`. Signed-off-by: Johan Fylling <johan.dev@fylling.se>
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
srenatus
approved these changes
May 27, 2024
|
Slept on it. No further epiphanies 😄. |
anakrish
added a commit
to anakrish/regorus
that referenced
this pull request
May 28, 2024
See open-policy-agent/opa#6763 Signed-off-by: Anand Krishnamoorthi <anakrish@microsoft.com>
anakrish
added a commit
to anakrish/regorus
that referenced
this pull request
May 28, 2024
See open-policy-agent/opa#6763 Signed-off-by: Anand Krishnamoorthi <anakrish@microsoft.com>
anakrish
added a commit
to microsoft/regorus
that referenced
this pull request
May 28, 2024
See open-policy-agent/opa#6763 Signed-off-by: Anand Krishnamoorthi <anakrish@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6762