Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12 shadinggeometry from simgeometry #21

Merged
merged 3 commits into from
Aug 19, 2024
Merged

12 shadinggeometry from simgeometry #21

merged 3 commits into from
Aug 19, 2024

Conversation

FlorianK13
Copy link
Member

@FlorianK13 FlorianK13 commented Aug 17, 2024 •
edited
Loading

Changes:

  • simulationGeometries are by default also pushed to shadingGeometries
  • Extended documentation

After merging this, we should have a new release to make development of the website easier.

@FlorianK13 FlorianK13 linked an issue Aug 17, 2024 that may be closed by this pull request
Scene.addShadingGeometry should not be necessary #12
Closed
@FlorianK13 FlorianK13 requested a review from khdlr August 17, 2024 13:58
@khdlr khdlr merged commit e7e297c into main Aug 19, 2024
2 checks passed
@FlorianK13 FlorianK13 deleted the 12-shadinggeometry-from-simgeometry branch August 19, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khdlr khdlr khdlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scene.addShadingGeometry should not be necessary
2 participants
@FlorianK13 @khdlr