Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make colormaps configurable #27

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Make colormaps configurable #27

merged 4 commits into from
Aug 30, 2024

Conversation

FlorianK13
Copy link
Member

@FlorianK13 FlorianK13 commented Aug 30, 2024 •
edited
Loading

  • Colormaps can be added to scene with addColorMap function (see main.ts line 94)
  • 3 predefined colormaps can be imported (for this to work I had to move the content from index.ts to main.ts)

@FlorianK13 FlorianK13 linked an issue Aug 30, 2024 that may be closed by this pull request
Make colormaps configurable #26
Closed
@FlorianK13 FlorianK13 requested a review from khdlr August 30, 2024 11:45
khdlr
khdlr approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@khdlr khdlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@khdlr khdlr merged commit aa3e702 into main Aug 30, 2024
2 checks passed
@FlorianK13 FlorianK13 deleted the 26-make-colormaps-configurable branch August 30, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khdlr khdlr khdlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make colormaps configurable
2 participants
@FlorianK13 @khdlr