Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shading from rasterized elevation data #5 #6

Closed
wants to merge 11 commits into from
Closed

Add shading from rasterized elevation data #5 #6

wants to merge 11 commits into from

Conversation

FlorianK13
Copy link
Member

No description provided.

@FlorianK13 FlorianK13 linked an issue Apr 22, 2024 that may be closed by this pull request
Create function to add a 2d array as elevation model #5
Closed
@FlorianK13 FlorianK13 marked this pull request as ready for review May 7, 2024 12:47
@FlorianK13 FlorianK13 requested a review from khdlr May 7, 2024 12:47
@FlorianK13
Copy link
Member Author

FlorianK13 commented May 7, 2024 •
edited
Loading

@MartGro @khdlr this is not really finished. But now the two branches for diffuse radiation and elevation need to work on the same code (as the shading involves both), so I think it is better to merge this one now to main to limit the amount of merge conflicts. Can one of you review the changes?

@FlorianK13 FlorianK13 self-assigned this May 7, 2024
@FlorianK13 FlorianK13 requested a review from MartGro May 7, 2024 12:49
@FlorianK13 FlorianK13 closed this May 13, 2024
@FlorianK13 FlorianK13 deleted the feature-5-elevation branch May 13, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khdlr khdlr Awaiting requested review from khdlr

@MartGro MartGro Awaiting requested review from MartGro

Assignees

@FlorianK13 FlorianK13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create function to add a 2d array as elevation model
1 participant
@FlorianK13