Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progress bar callback function #7 #8

Merged
merged 4 commits into from
May 6, 2024
Merged

Add progress bar callback function #7 #8

merged 4 commits into from
May 6, 2024

Conversation

FlorianK13
Copy link
Member

No description provided.

@FlorianK13 FlorianK13 linked an issue May 6, 2024 that may be closed by this pull request
Add callback function for progress bar #7
Closed
@FlorianK13 FlorianK13 requested a review from khdlr May 6, 2024 09:11
@FlorianK13
Copy link
Member Author

@khdlr I did not come up with a test for that, maybe we merge it now and test it as soon as we integrate it in our frontend?

@FlorianK13
Copy link
Member Author

@khdlr can you add your review so that I can merge?

khdlr
khdlr requested changes May 6, 2024
View reviewed changes
Copy link
Member

@khdlr khdlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing / 3 when calling the progress callback

src/rayTracingWebGL.ts Outdated Show resolved Hide resolved
@khdlr
Copy link
Member

khdlr commented May 6, 2024

Sorry, didn't realise it's a two step process where I have to first "start a review" and then "finalize the review" 😅

khdlr
khdlr requested changes May 6, 2024
View reviewed changes
Copy link
Member

@khdlr khdlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need it for i as well :)

@FlorianK13
Copy link
Member Author

We need it for i as well :)

Ups...

@FlorianK13 FlorianK13 merged commit f7ad0ad into main May 6, 2024
2 checks passed
@FlorianK13 FlorianK13 deleted the feature-7-callback-progress-bar branch May 6, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khdlr khdlr khdlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add callback function for progress bar
2 participants
@FlorianK13 @khdlr