Aaron/react 18 #729
Merged
Aaron/react 18 #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Codecov Report
@@ Coverage Diff @@
## cr/react-18 #729 +/- ##
===============================================
- Coverage 38.05% 33.44% -4.62%
===============================================
Files 165 131 -34
Lines 4223 3657 -566
Branches 938 833 -105
===============================================
- Hits 1607 1223 -384
+ Misses 2418 2296 -122
+ Partials 198 138 -60
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…e are testing Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Angatupyry
approved these changes
Jul 26, 2023
aaronchongth
added a commit
that referenced
this pull request
Jul 27, 2023
* Update to 18 rmf auth Signed-off-by: angatupyry <fierrofenix@gmail.com> * Update to react router v6 Signed-off-by: angatupyry <fierrofenix@gmail.com> * Update to 18 rmf component Signed-off-by: angatupyry <fierrofenix@gmail.com> * Add prop to render children Signed-off-by: angatupyry <fierrofenix@gmail.com> * Update to 18 dashboard Signed-off-by: angatupyry <fierrofenix@gmail.com> * Update lock file Signed-off-by: angatupyry <fierrofenix@gmail.com> * Porting to react 18 Signed-off-by: angatupyry <fierrofenix@gmail.com> * Add pathname harcode to render tab name correctly Signed-off-by: angatupyry <fierrofenix@gmail.com> * Adding * to render nested routes Signed-off-by: angatupyry <fierrofenix@gmail.com> * Remove close tag Signed-off-by: angatupyry <fierrofenix@gmail.com> * Remove testing console Signed-off-by: angatupyry <fierrofenix@gmail.com> * Adding nested routes Signed-off-by: angatupyry <fierrofenix@gmail.com> * Remove useMatch and pass only username to render child route properly Signed-off-by: angatupyry <fierrofenix@gmail.com> * Drawing routes according to react router v6 Signed-off-by: angatupyry <fierrofenix@gmail.com> * Removing unused import Signed-off-by: angatupyry <fierrofenix@gmail.com> * Render user profile by username Signed-off-by: angatupyry <fierrofenix@gmail.com> * Update react testing library Signed-off-by: angatupyry <fierrofenix@gmail.com> * Updating react testing library package and use fireevent instead of userEvent Signed-off-by: angatupyry <fierrofenix@gmail.com> * Use fireevent instead of userEvent Signed-off-by: angatupyry <fierrofenix@gmail.com> * Use fireevent instead of userEvent Signed-off-by: angatupyry <fierrofenix@gmail.com> * Update test according to react 18 Signed-off-by: angatupyry <fierrofenix@gmail.com> * Remove userEvent and use fireevent instad Signed-off-by: angatupyry <fierrofenix@gmail.com> * Add describe to wrap testing and use fire event instead of userevent Signed-off-by: angatupyry <fierrofenix@gmail.com> * FireEvent instead of userEvent Signed-off-by: angatupyry <fierrofenix@gmail.com> * Wrap test into describe Signed-off-by: angatupyry <fierrofenix@gmail.com> * Wrap test into describe Signed-off-by: angatupyry <fierrofenix@gmail.com> * Add fireevent instead of userevent. Signed-off-by: angatupyry <fierrofenix@gmail.com> * FireEvent added and waitFor expect Signed-off-by: angatupyry <fierrofenix@gmail.com> * Remove unnecessary function to render component Signed-off-by: angatupyry <fierrofenix@gmail.com> * Remove test comment Signed-off-by: angatupyry <fierrofenix@gmail.com> * Using testing library renderHook Signed-off-by: angatupyry <fierrofenix@gmail.com> * Update react testing library Signed-off-by: angatupyry <fierrofenix@gmail.com> * Adding function to avoid warning act(...) Signed-off-by: angatupyry <fierrofenix@gmail.com> * Fix test according to the new version of testing library Signed-off-by: angatupyry <fierrofenix@gmail.com> * Adding beforeAll code test to silence warning Signed-off-by: angatupyry <fierrofenix@gmail.com> * Comment test failed Signed-off-by: angatupyry <fierrofenix@gmail.com> * Create a use stack navigator test acording to new version of testing library Signed-off-by: angatupyry <fierrofenix@gmail.com> * Add comment to explain change Signed-off-by: angatupyry <fierrofenix@gmail.com> * main admin path Navigate to users Signed-off-by: angatupyry <fierrofenix@gmail.com> * Improve function to be more easy to read Signed-off-by: angatupyry <fierrofenix@gmail.com> * Fix test in log table report and useasync function Signed-off-by: angatupyry <fierrofenix@gmail.com> * Remove unused import Signed-off-by: angatupyry <fierrofenix@gmail.com> * Aaron/react 18 (#729) * Adding link to unresolved issue to testing Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Added back missing test Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Reverting stack navigator tests Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Remove the rest of reporting components from react-components Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Remove deprecated command forms Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Revert to remove expectation of loading text since that is not what we are testing Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Add DashboardRoute to the route map since it returns undefined anyway Signed-off-by: Aaron Chong <aaronchongth@gmail.com> --------- Signed-off-by: Aaron Chong <aaronchongth@gmail.com> --------- Signed-off-by: angatupyry <fierrofenix@gmail.com> Signed-off-by: Aaron Chong <aaronchongth@gmail.com> Co-authored-by: Aaron Chong <aaronchongth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
This is used for testing the migration and implementing suggestions while testing.
react-components/lib/commandsandreact-components/lib/reportsSelf-checks
Discussion