Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catching MultipleObjectsReturned, logging that only a single map is supported #730

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

aaronchongth
Copy link
Member

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

…upported

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #730 (616b54c) into main (22355c1) will decrease coverage by 0.03%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
- Coverage   54.68%   54.66%   -0.03%     
==========================================
  Files         261      261              
  Lines        6473     6480       +7     
  Branches      836      836              
==========================================
+ Hits         3540     3542       +2     
- Misses       2795     2800       +5     
  Partials      138      138              
Flag Coverage Δ
api-server 82.59% <37.50%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...es/api-server/api_server/rmf_io/health_watchdog.py 77.10% <37.50%> (-2.14%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@akash-roboticist
Copy link
Contributor

Thanks for adding this Aaron, this is really helpful!!

Copy link
Contributor

@akash-roboticist akash-roboticist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronchongth aaronchongth merged commit ac76ae9 into main Jul 27, 2023
3 checks passed
@aaronchongth aaronchongth deleted the doc/multiple-map-error branch July 27, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants