Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropoff points to show waypoint/place names instead of ingesters #760

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

aaronchongth
Copy link
Member

What's new

Fix dropoff points for hunting delivery tasks.

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #760 (7a567dd) into deploy/hammer (de3a5ad) will decrease coverage by 0.21%.
Report is 11 commits behind head on deploy/hammer.
The diff coverage is 3.29%.

@@                Coverage Diff                @@
##           deploy/hammer     #760      +/-   ##
=================================================
- Coverage          54.26%   54.05%   -0.21%     
=================================================
  Files                263      263              
  Lines               6583     6610      +27     
  Branches             875      890      +15     
=================================================
+ Hits                3572     3573       +1     
- Misses              2871     2897      +26     
  Partials             140      140              
Flag Coverage Δ
dashboard 17.86% <5.66%> (-0.15%) ⬇️
react-components 52.24% <0.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...i-server/api_server/models/rmf_api/task_request.py 100.00% <ø> (ø)
...api-server/api_server/models/rmf_api/task_state.py 100.00% <ø> (ø)
...-server/api_server/models/tortoise_models/tasks.py 100.00% <ø> (ø)
...kages/api-server/api_server/repositories/alerts.py 30.50% <ø> (ø)
...ckages/api-server/api_server/repositories/tasks.py 82.22% <ø> (-0.20%) ⬇️
packages/api-server/api_server/routes/internal.py 80.26% <ø> (ø)
...ckages/api-server/api_server/routes/tasks/tasks.py 78.78% <ø> (-0.22%) ⬇️
packages/dashboard/src/components/app-base.tsx 0.00% <0.00%> (ø)
packages/dashboard/src/components/map-app.tsx 0.00% <0.00%> (ø)
...ages/dashboard/src/components/tasks/task-alert.tsx 0.00% <0.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth merged commit 4f0a084 into deploy/hammer Aug 31, 2023
4 checks passed
@aaronchongth aaronchongth deleted the hammer/fix-dropoff-points branch August 31, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant