Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting a favorite task changes taskRequests, instead of append #761

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

aaronchongth
Copy link
Member

What's new

Selecting a favorite task set it as the main task, instead of appending it to a list of task.

This fixes the issue of including the default task.

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #761 (ee1ec17) into main (aab9408) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #761   +/-   ##
=======================================
  Coverage   54.25%   54.25%           
=======================================
  Files         263      263           
  Lines        6588     6587    -1     
  Branches      877      877           
=======================================
  Hits         3574     3574           
+ Misses       2874     2873    -1     
  Partials      140      140           
Flag Coverage Δ
dashboard 18.06% <ø> (ø)
react-components 52.11% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ackages/react-components/lib/tasks/create-task.tsx 2.38% <0.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaronchongth aaronchongth merged commit 274ca26 into main Aug 31, 2023
4 checks passed
@aaronchongth aaronchongth deleted the fix/favorite-tasks-select branch August 31, 2023 04:32
@aaronchongth aaronchongth mentioned this pull request Aug 31, 2023
5 tasks
aaronchongth added a commit that referenced this pull request Aug 31, 2023
…) (#762)

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
aaronchongth added a commit that referenced this pull request Sep 8, 2023
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
(cherry picked from commit 274ca26)
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth mentioned this pull request Sep 8, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant