Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed hammer categories #772

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Renamed hammer categories #772

merged 3 commits into from
Sep 15, 2023

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Sep 15, 2023

What's new

Renaming to delivery_sequential_lot_pickup and delivery_area_pickup

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #772 (18df4fe) into deploy/hammer (26d635a) will decrease coverage by 0.33%.
Report is 2 commits behind head on deploy/hammer.
The diff coverage is 0.00%.

@@                Coverage Diff                @@
##           deploy/hammer     #772      +/-   ##
=================================================
- Coverage          54.20%   53.88%   -0.33%     
=================================================
  Files                263      263              
  Lines               6619     6659      +40     
  Branches             886      892       +6     
=================================================
  Hits                3588     3588              
- Misses              2891     2931      +40     
  Partials             140      140              
Flag Coverage Δ
dashboard 17.68% <ø> (ø)
react-components 52.33% <0.00%> (-1.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ackages/react-components/lib/tasks/create-task.tsx 2.44% <0.00%> (-0.40%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth changed the title Renamed frontend for categories Renamed hammer categories Sep 15, 2023
@aaronchongth aaronchongth merged commit d1ac654 into deploy/hammer Sep 15, 2023
4 checks passed
@aaronchongth aaronchongth deleted the hammer/rename-fields branch September 15, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant