Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/alignment #774

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Fix/alignment #774

merged 2 commits into from
Sep 18, 2023

Conversation

Angatupyry
Copy link
Collaborator

What's new

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

@aaronchongth
Alignment fixes using scale and offset
aaf1c86 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Use level offset properly
1651605 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@Angatupyry Angatupyry merged commit 9f8f581 into feature/threefiber-map Sep 18, 2023
1 of 3 checks passed
@Angatupyry Angatupyry deleted the fix/alignment branch September 18, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Angatupyry @aaronchongth