Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port schedule editing to hammer #780

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

Angatupyry
Copy link
Collaborator

What's new

Porting in

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Signed-off-by: angatupyry <fierrofenix@gmail.com>
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #780 (a038a7b) into deploy/hammer (26d635a) will increase coverage by 0.46%.
Report is 4 commits behind head on deploy/hammer.
The diff coverage is 15.38%.

@@                Coverage Diff                @@
##           deploy/hammer     #780      +/-   ##
=================================================
+ Coverage          54.20%   54.67%   +0.46%     
=================================================
  Files                263      264       +1     
  Lines               6619     6577      -42     
  Branches             886      864      -22     
=================================================
+ Hits                3588     3596       +8     
+ Misses              2891     2841      -50     
  Partials             140      140              
Flag Coverage Δ
api-server 81.21% <10.34%> (-0.73%) ⬇️
react-components 51.72% <17.33%> (-1.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/dashboard/src/components/appbar.tsx 34.11% <ø> (+3.98%) ⬆️
...kages/dashboard/src/components/tasks/tasks-app.tsx 0.00% <ø> (ø)
packages/dashboard/src/components/tasks/utils.ts 0.00% <ø> (ø)
...ackages/react-components/lib/tasks/create-task.tsx 3.71% <7.57%> (+0.86%) ⬆️
...-server/api_server/routes/tasks/scheduled_tasks.py 59.48% <10.34%> (-16.38%) ⬇️
packages/react-components/lib/form-inputs.tsx 80.00% <75.00%> (+5.00%) ⬆️
...ib/tasks/task-schedule-event-edit-delete-popup.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting this over! It's working well, LGTM!

@aaronchongth aaronchongth merged commit a24fdaf into deploy/hammer Sep 20, 2023
6 checks passed
@aaronchongth aaronchongth deleted the port/schedule-editing branch September 20, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants