Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to UI to make filters and sorting work #959

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Changes to UI to make filters and sorting work #959

merged 1 commit into from
Jun 24, 2024

Conversation

aaronchongth
Copy link
Member

What's new

Changes required for UI to work

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

@aaronchongth
Changes to UI to make filters and sorting work
0bf2144 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth mentioned this pull request Jun 24, 2024
Merged
5 tasks
koonpeng
koonpeng approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@koonpeng koonpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes shouldn't be needed but good to have.

@aaronchongth aaronchongth merged commit b8c665a into koonpeng/deploy-fix-postgres Jun 24, 2024
3 checks passed
@aaronchongth aaronchongth deleted the ac/postgres-fixes-ui branch June 24, 2024 07:08
aaronchongth added a commit that referenced this pull request Jun 24, 2024
@koonpeng @aaronchongth
api-server: port postgres fix to deploy/hammer (#958)
d2e56f3 
* port postgres fix by avoiding changes to Pipfile

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

* fix lint

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

* revert pnpm-lock

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>

* Changes to UI to make filters and sorting work (#959)

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Co-authored-by: Aaron Chong <aaronchongth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koonpeng koonpeng koonpeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronchongth @koonpeng